Drop redundant gandalfPageViewCount in favour of dailyArticleCount

gandalfPageViewCount duplicated dailyArticleCount (same
gu.history.dailyArticleCount source, sent 0-based instead of 1-based).
SDC now applies the Gandalf free-allowance rule to the existing
dailyArticleCount field the client already sends.

Author: Juarez Mota

dotcom-rendering/playwright/tests/banner.e2e.spec.ts

@@ -167,9 +167,9 @@ test.describe('Sign-in gate portal', function () {
 		const auxiaRequest = await auxiaRequestPromise;
 		const body = auxiaRequest.postDataJSON() as Record<string, unknown>;
 		expect(body.countryCode).toBe('NZ');
-		// Two article loads today (each increments gu.history.dailyArticleCount),
-		// sent 0-based, so the second load sends 1.
-		expect(body.gandalfPageViewCount).toBe(1);
+		// Two article loads today, each increments gu.history.dailyArticleCount
+		// including the current pageview, so the second load sends 2.
+		expect(body.dailyArticleCount).toBe(2);
 	});
 });
 

dotcom-rendering/src/components/SignInGate/types.ts

@@ -137,7 +137,6 @@ export interface AuxiaProxyGetTreatmentsPayload {
 	showDefaultGate: ShowGateValues; // [3]
 	gateDisplayCount: number;
 	hideSupportMessagingTimestamp: number | undefined; // [4]
-	gandalfPageViewCount?: number; // [5] gandalfPageViewCount
 }
 
 // [1]
@@ -184,21 +183,17 @@ export interface AuxiaProxyGetTreatmentsPayload {
 // It is either undefined or return the timestamp carried by cookie `gu_hide_support_messaging`
 // See: https://github.com/guardian/support-frontend/blob/7a5c0f9209054c24934b876771392531c261f51c/support-frontend/assets/helpers/storage/contributionsCookies.ts#L11
 
-// [5] gandalfPageViewCount
+// [5] (comment group: gandalf)
 //
 // date: 2nd September 2026
-// comment group: gandalf
 //
 // "Gandalf" is the marketing name for the Guardian-managed sign-in gate
 // journey: a 100% rollout run entirely by Guardian rules with no Auxia
 // involvement, currently live for New Zealand and extendable to further
-// countries via the gandalfSignInGateCountries channel switch.
-//
-// `gandalfPageViewCount` is the 0-based number of views the reader has
-// already completed today (gu.history.dailyArticleCount, see
-// src/lib/dailyArticleCount.ts). It is optional so older payloads and traffic
-// outside the Gandalf countries are unaffected; SDC treats a missing value
-// as 0.
+// countries via the gandalfSignInGateCountries channel switch. SDC drives
+// the journey from the standard dailyArticleCount field (the reader's
+// pageview count for the current day, including this pageview) — see
+// gandalfSignInGate on AuxiaProxyGetTreatmentsProxyResponseData below.
 
 export interface AuxiaProxyGetTreatmentsResponse {
 	status: boolean;
@@ -209,10 +204,10 @@ export interface AuxiaProxyGetTreatmentsProxyResponseData {
 	responseId: string;
 	userTreatment?: AuxiaAPIResponseDataUserTreatment;
 	// Set to true on responses produced by the active Gandalf rules, both
-	// when no gate should display (the pageview still counts towards the free
-	// allowance) and when the Guardian-managed non-dismissible popup is
-	// returned. When present, the client must not make any Auxia interaction
-	// call and reports to Ophan under the stable Gandalf identity.
+	// when no gate should display and when the Guardian-managed
+	// non-dismissible popup is returned. When present, the client must not
+	// make any Auxia interaction call and reports to Ophan under the stable
+	// Gandalf identity.
 	gandalfSignInGate?: boolean;
 }
 

dotcom-rendering/src/components/StickyBottomBanner/SignInGatePortal.test.tsx

@@ -1,7 +1,6 @@
 // Mock the auxia module before imports so the mock is applied when the module
 // under test is evaluated.
 import { buildAuxiaGateDisplayData } from '../../lib/auxia';
-import { getDailyArticleCount, getToday } from '../../lib/dailyArticleCount';
 import type { AuxiaAPIResponseDataUserTreatment } from '../SignInGate/types';
 import type { AuxiaGateDisplayData } from '../SignInGate/types';
 import type { CanShowSignInGateProps } from './SignInGatePortal';
@@ -12,20 +11,12 @@ jest.mock('../../lib/auxia', () => ({
 	buildAuxiaGateDisplayData: jest.fn(),
 }));
 
-jest.mock('../../lib/dailyArticleCount', () => ({
-	getDailyArticleCount: jest.fn().mockReturnValue(undefined),
-	getToday: jest.fn().mockReturnValue(200),
-}));
-
 // Mock document.getElementById
 const mockGetElementById = jest.fn();
 Object.defineProperty(document, 'getElementById', {
 	value: mockGetElementById,
 });
 
-const mockGetDailyArticleCount = jest.mocked(getDailyArticleCount);
-const mockGetToday = jest.mocked(getToday);
-
 const canShowProps: CanShowSignInGateProps = {
 	isSignedIn: false,
 	isPaidContent: false,
@@ -222,56 +213,6 @@ describe('SignInGatePortal', () => {
 	});
 
 	describe('Gandalf (Guardian-managed sign-in gate journey)', () => {
-		it('sends today’s view count (0-based) to SDC', async () => {
-			mockGetElementById.mockReturnValue(document.createElement('div'));
-			// 4 views today: the current pageview is included, so the portal
-			// sends 3 (0-based).
-			mockGetDailyArticleCount.mockReturnValue([{ day: 200, count: 4 }]);
-			mockGetToday.mockReturnValue(200);
-			(
-				buildAuxiaGateDisplayData as jest.MockedFunction<
-					typeof buildAuxiaGateDisplayData
-				>
-			).mockResolvedValue(makeAuxiaReturn(undefined, true));
-
-			await canShowSignInGatePortal(canShowProps);
-
-			expect(buildAuxiaGateDisplayData).toHaveBeenCalledWith(
-				'https://contributions.local',
-				'page-id',
-				'UK',
-				'Article',
-				'section',
-				[],
-				0,
-				3,
-			);
-		});
-
-		it('sends 0 when the latest daily count is not from today', async () => {
-			mockGetElementById.mockReturnValue(document.createElement('div'));
-			mockGetDailyArticleCount.mockReturnValue([{ day: 199, count: 9 }]);
-			mockGetToday.mockReturnValue(200);
-			(
-				buildAuxiaGateDisplayData as jest.MockedFunction<
-					typeof buildAuxiaGateDisplayData
-				>
-			).mockResolvedValue(makeAuxiaReturn(undefined, true));
-
-			await canShowSignInGatePortal(canShowProps);
-
-			expect(buildAuxiaGateDisplayData).toHaveBeenCalledWith(
-				'https://contributions.local',
-				'page-id',
-				'UK',
-				'Article',
-				'section',
-				[],
-				0,
-				0,
-			);
-		});
-
 		it('returns no gate but carries the marker metadata on a free Gandalf pageview', async () => {
 			mockGetElementById.mockReturnValue(document.createElement('div'));
 			(

dotcom-rendering/src/components/StickyBottomBanner/SignInGatePortal.tsx

@@ -2,7 +2,6 @@ import type { CountryCode } from '@guardian/libs';
 import { useCallback, useEffect, useMemo, useState } from 'react';
 import { createPortal } from 'react-dom';
 import { buildAuxiaGateDisplayData } from '../../lib/auxia';
-import { getDailyArticleCount, getToday } from '../../lib/dailyArticleCount';
 import type { EditionId } from '../../lib/edition';
 import type { CanShowResult } from '../../lib/messagePicker';
 import { useAuthStatus } from '../../lib/useAuthStatus';
@@ -197,17 +196,6 @@ export const canShowSignInGatePortal = async ({
 	}
 
 	try {
-		// Today's view count (gu.history.dailyArticleCount). The count is
-		// incremented for the current pageview before the banner flow runs,
-		// so it is 1-based: the 4th view of the day sends 3. SDC only
-		// consumes this for active Gandalf traffic.
-		const dailyHistory = getDailyArticleCount();
-		const latestDay = dailyHistory?.[0];
-		const viewCountToday =
-			latestDay?.day === getToday()
-				? Math.max(latestDay.count - 1, 0)
-				: 0;
-
 		const auxiaData = await buildAuxiaGateDisplayData(
 			contributionsServiceUrl,
 			pageId,
@@ -216,7 +204,6 @@ export const canShowSignInGatePortal = async ({
 			sectionId,
 			tags,
 			retrieveLastGateDismissedCount('AuxiaSignInGate'),
-			viewCountToday,
 		);
 
 		const meta = (

dotcom-rendering/src/lib/auxia.ts

@@ -125,7 +125,6 @@ const fetchProxyGetTreatments = async (
 	showDefaultGate: ShowGateValues,
 	gateDisplayCount: number,
 	hideSupportMessagingTimestamp: number | undefined,
-	gandalfPageViewCount?: number,
 ): Promise<AuxiaProxyGetTreatmentsResponse> => {
 	const articleIdentifier = `www.theguardian.com/${pageId}`;
 	const url = `${contributionsServiceUrl}/auxia/get-treatments`;
@@ -148,7 +147,6 @@ const fetchProxyGetTreatments = async (
 		showDefaultGate,
 		gateDisplayCount,
 		hideSupportMessagingTimestamp,
-		gandalfPageViewCount,
 	};
 
 	const params = { method: 'POST', headers, body: JSON.stringify(payload) };
@@ -217,7 +215,6 @@ export const buildAuxiaGateDisplayData = async (
 	sectionId: string,
 	tags: TagType[],
 	gateDismissCount: number,
-	gandalfPageViewCount?: number,
 ): Promise<AuxiaGateDisplayData | undefined> => {
 	const readerPersonalData = await decideAuxiaProxyReaderPersonalData();
 	const tagIds = tags.map((tag) => tag.id);
@@ -245,7 +242,6 @@ export const buildAuxiaGateDisplayData = async (
 		showDefaultGate,
 		gateDisplayCount,
 		hideSupportMessagingTimestamp,
-		gandalfPageViewCount,
 	);
 
 	if (response.status && response.data) {