Commit 4797dd7
Wire optional PuzzleConfig.image into og:image/twitter:image + test coverage
- src/server/render.puzzlePage.web.tsx: extracted the description/
openGraphData/twitterData construction into a new, pure, exported
buildPuzzlePageMetaData(webTitle, puzzleConfig) function (previously
inline in renderPuzzlePage). This is specifically so it's directly unit
testable without needing to invoke the full render pipeline, which
requires a webpack build manifest not present in the test environment -
there is no render.*.web.tsx unit test convention anywhere else in this
repo to extend, so extracting the pure logic avoids inventing new
render-pipeline test infrastructure just for this. openGraphData/
twitterData now conditionally spread in 'og:image'/'twitter:image' only
when puzzleConfig.image is set - when it's unset, the keys are omitted
entirely (not sent as an empty string or placeholder), matching how
htmlPageTemplate's generateMetaTags() only emits a <meta> tag for keys
actually present in the object (verified by reading its
Object.entries()-based implementation before assuming this).
- fixtures/manual/puzzlePage.ts: added samplePuzzleImageUrl (a clearly
fixture-only placeholder image URL) and createPuzzleConfigWithImage(slug),
a fixture-only helper returning a copy of a real registry PuzzleConfig
with image set - used to exercise the with-image branch in tests without
touching the real registry itself (which still has no image configured
on any of the 6 V0 entries, per the previous commit).
- src/server/render.puzzlePage.web.test.ts (new): 4 tests for
buildPuzzlePageMetaData - description sourced from puzzleConfig,
og:title/twitter:title from webTitle, og:image/twitter:image omitted
entirely when image is unset, and included with the correct value when
set (using the new fixture helper).
tsc --noEmit clean, eslint clean, 5 suites / 51 tests passing across all
Puzzle Page test files (no regressions).
Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>1 parent 4af65b6 commit 4797dd7
3 files changed
Lines changed: 128 additions & 9 deletions
File tree
- dotcom-rendering
- fixtures/manual
- src/server
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
1 | 2 | | |
2 | 3 | | |
3 | 4 | | |
| |||
87 | 88 | | |
88 | 89 | | |
89 | 90 | | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
| 97 | + | |
| 98 | + | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
| 108 | + | |
| 109 | + | |
| 110 | + | |
| 111 | + | |
| 112 | + | |
| 113 | + | |
| 114 | + | |
| 115 | + | |
| 116 | + | |
Lines changed: 53 additions & 0 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
| 7 | + | |
| 8 | + | |
| 9 | + | |
| 10 | + | |
| 11 | + | |
| 12 | + | |
| 13 | + | |
| 14 | + | |
| 15 | + | |
| 16 | + | |
| 17 | + | |
| 18 | + | |
| 19 | + | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
11 | 11 | | |
12 | 12 | | |
13 | 13 | | |
| 14 | + | |
14 | 15 | | |
15 | 16 | | |
16 | 17 | | |
17 | 18 | | |
18 | 19 | | |
| 20 | + | |
| 21 | + | |
| 22 | + | |
| 23 | + | |
| 24 | + | |
| 25 | + | |
| 26 | + | |
| 27 | + | |
| 28 | + | |
| 29 | + | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
| 33 | + | |
| 34 | + | |
| 35 | + | |
| 36 | + | |
| 37 | + | |
| 38 | + | |
| 39 | + | |
| 40 | + | |
| 41 | + | |
| 42 | + | |
| 43 | + | |
| 44 | + | |
| 45 | + | |
| 46 | + | |
| 47 | + | |
| 48 | + | |
| 49 | + | |
| 50 | + | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
| 54 | + | |
| 55 | + | |
| 56 | + | |
| 57 | + | |
| 58 | + | |
| 59 | + | |
| 60 | + | |
| 61 | + | |
| 62 | + | |
19 | 63 | | |
20 | 64 | | |
21 | 65 | | |
| |||
68 | 112 | | |
69 | 113 | | |
70 | 114 | | |
71 | | - | |
72 | | - | |
73 | | - | |
74 | | - | |
75 | | - | |
76 | | - | |
77 | | - | |
78 | | - | |
79 | | - | |
| 115 | + | |
| 116 | + | |
| 117 | + | |
| 118 | + | |
80 | 119 | | |
81 | 120 | | |
82 | 121 | | |
| |||
0 commit comments