Skip to content

Commit 53c842c

Browse files
Remove em dashes across branch per new house style rule
Pure copy-editing pass, no functional/behavioural change. Replaces every em dash (—) in docs/puzzle-page.md and the Puzzle Page source comments touched by this branch with a comma, a new sentence, or a plain hyphen, whichever reads most naturally, per a new permanent house-style rule against using em dashes anywhere. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
1 parent 5c59c20 commit 53c842c

7 files changed

Lines changed: 76 additions & 75 deletions

File tree

ab-testing/config/abTests.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -158,7 +158,7 @@ const ABTests: ABTest[] = [
158158
shouldForceMetricsCollection: false,
159159
},
160160
/**
161-
* Puzzles & Games rollout tier v0 (the master switch).
161+
* Puzzles & Games rollout, tier v0 (the master switch).
162162
*
163163
* Gates the baseline Puzzles & Games experience: the new Puzzles Hub
164164
* page, and the 6 V0 puzzle pages (sudoku easy/medium/hard/killer,
@@ -167,7 +167,7 @@ const ABTests: ABTest[] = [
167167
* from puzzles" rail, and the hub's sub-nav has no links yet.
168168
*
169169
* This is the master switch for the whole Puzzles & Games experience:
170-
* turning it off (or down to 0%) hides everything the hub, the V0
170+
* turning it off (or down to 0%) hides everything: the hub, the V0
171171
* puzzle pages, and (by the cumulative design below) every later tier
172172
* too, since v1/v2 only take effect when this is also enabled.
173173
*
@@ -190,10 +190,10 @@ const ABTests: ABTest[] = [
190190
shouldForceMetricsCollection: false,
191191
},
192192
/**
193-
* Puzzles & Games rollout tier v1 (w/c 12 Oct launch).
193+
* Puzzles & Games rollout, tier v1 (w/c 12 Oct launch).
194194
*
195195
* Only takes effect when `puzzles-new-hub` (v0) is ALSO enabled for the
196-
* reader — this test does nothing on its own, by design, so the
196+
* reader. This test does nothing on its own, by design, so the
197197
* rollout can never end up in an inconsistent state (e.g. v1 features
198198
* showing while the v0 baseline they build on is switched off).
199199
*
@@ -224,11 +224,11 @@ const ABTests: ABTest[] = [
224224
shouldForceMetricsCollection: false,
225225
},
226226
/**
227-
* Puzzles & Games rollout tier v2 (future, no launch date confirmed
227+
* Puzzles & Games rollout, tier v2 (future, no launch date confirmed
228228
* yet as of this writing).
229229
*
230230
* Only takes effect when BOTH `puzzles-new-hub` (v0) AND
231-
* `puzzles-new-hub-v1` are ALSO enabled for the reader same
231+
* `puzzles-new-hub-v1` are ALSO enabled for the reader, same
232232
* cumulative-by-design principle as v1 above, applied one tier further.
233233
*
234234
* On top of v0+v1, this tier activates: the On the Ball and Film Reveal

dotcom-rendering/docs/puzzle-page.md

Lines changed: 62 additions & 61 deletions
Large diffs are not rendered by default.

dotcom-rendering/fixtures/manual/puzzlePage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ const sampleMoreFromPuzzlesAndGames: PuzzleItem[] = [
2828
/**
2929
* Illustrative canonical URL matching `frontend`'s public URL shape for
3030
* puzzle pages (top-level, mirroring crosswords, distinct from the
31-
* `/puzzles-and-games` hub) purely a fixture value, not something DCR
31+
* `/puzzles-and-games` hub), purely a fixture value, not something DCR
3232
* validates or enforces the shape of.
3333
*/
3434
const canonicalUrlForSlug = (slug: string): string => {

dotcom-rendering/src/layouts/PuzzlePageLayout.tsx

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,11 +34,11 @@ import type { FEPuzzlePageType } from '../types/puzzlePage';
3434
* blocks (Masthead, Section, Footer, AdSlot, ShareButton.island) rather than
3535
* duplicating them.
3636
*
37-
* Puzzle Page is scoped to iframe-based puzzles only crosswords remain on
37+
* Puzzle Page is scoped to iframe-based puzzles only, crosswords remain on
3838
* their existing, separate `/crosswords/*` flow
3939
* (`ArticleDesign.Crossword` / `src/layouts/CrosswordLayout.tsx`), which is
4040
* unrelated to this layout. There is accordingly no setter byline, PDF
41-
* link, or comments rendering here none of the current `PuzzleConfig`
41+
* link, or comments rendering here, none of the current `PuzzleConfig`
4242
* registry entries have any equivalent concept.
4343
*/
4444

@@ -53,7 +53,7 @@ const puzzleGroupLabels: Record<PuzzleConfig['puzzleGroup'], string> = {
5353
* no equivalent concept, so a minimal, fixed format value is used to satisfy
5454
* its prop contract without fabricating article-specific data (tags,
5555
* branding, etc.). This is read-only reuse of existing exported enum
56-
* values it does not modify `articleFormat.ts` or any crossword decision
56+
* values, it does not modify `articleFormat.ts` or any crossword decision
5757
* logic.
5858
*/
5959
const puzzlePageFormat = {

dotcom-rendering/src/model/puzzles/puzzleConfigs.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
* DCR's single source of truth for the structural/rendering behaviour of
33
* each supported Puzzle Page slug.
44
*
5-
* Puzzle Page is scoped to iframe-based puzzles only crosswords remain on
5+
* Puzzle Page is scoped to iframe-based puzzles only, crosswords remain on
66
* their existing, separate `/crosswords/*` flow
77
* (`ArticleDesign.Crossword` / `src/layouts/CrosswordLayout.tsx`), which is
88
* unrelated to this registry and is not unified into Puzzle Page. See

dotcom-rendering/src/model/validate.puzzlePage.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ import {
1818
* `editions`) exported from `validate.ts` rather than duplicating them.
1919
*
2020
* Note: unlike some other DCR page types, there was no pre-existing
21-
* `validate.<pageType>.ts` file to mirror here every other page type's
21+
* `validate.<pageType>.ts` file to mirror here, every other page type's
2222
* validator (including the unrelated Puzzles Hub's `validateAsPuzzlesPageType`)
2323
* still lives in the shared `validate.ts`, only their *tests* are split
2424
* into per-page-type files (e.g. `validate.puzzlesPage.test.ts`). This file

dotcom-rendering/src/types/puzzlePage.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@ import type { PuzzleItem } from './puzzlesPage';
99
* (currently just the title, plus optional related-content links) resolved
1010
* by frontend for a given puzzle `slug`.
1111
*
12-
* Puzzle Page is scoped to iframe-based puzzles only there is no
12+
* Puzzle Page is scoped to iframe-based puzzles only, there is no
1313
* component-rendered case (crosswords remain on their existing, separate
1414
* `/crosswords/*` flow), so this type carries no crossword-specific fields.
1515
*/
@@ -20,7 +20,7 @@ export interface PuzzlePageInstance {
2020
* (e.g. `"2026-09-11"`). This is prep work for a future V1
2121
* calendar-navigation feature (the reader will be able to navigate from
2222
* a calendar to a specific past puzzle, so the page won't always show
23-
* "today's" puzzle) DCR currently accepts and validates this field
23+
* "today's" puzzle). DCR currently accepts and validates this field
2424
* but does **not** yet wire it into any rendering logic or the iframe
2525
* URL. See "Open questions" in `docs/puzzle-page.md`.
2626
*

0 commit comments

Comments
 (0)