Skip to content

Commit 70b1835

Browse files
authored
Merge branch 'main' into jm/feat-refactor-banner-component
2 parents 543fc35 + 97e6422 commit 70b1835

54 files changed

Lines changed: 2889 additions & 4326 deletions

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.github/workflows/check-labels.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -6,4 +6,4 @@ on:
66
types: [opened, labeled, unlabeled, synchronize, reopened, edited]
77
jobs:
88
require-label:
9-
uses: guardian/.github/.github/workflows/require-label.yaml@d8e99387686ec439e37c883ba9bb8ab2b43a6b81 # v3.0.0
9+
uses: guardian/.github/.github/workflows/require-label.yaml@02937505d39c570351300878870233e0b1a5e073 # v3.1.0

ab-testing/cdk/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -21,8 +21,8 @@
2121
]
2222
},
2323
"devDependencies": {
24-
"@aws-sdk/client-s3": "3.931.0",
25-
"@aws-sdk/client-ssm": "3.621.0",
24+
"@aws-sdk/client-s3": "3.991.0",
25+
"@aws-sdk/client-ssm": "3.991.0",
2626
"@guardian/cdk": "62.0.1",
2727
"@guardian/eslint-config": "12.0.1",
2828
"@guardian/tsconfig": "1.0.1",

ab-testing/config/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -28,8 +28,8 @@
2828
]
2929
},
3030
"devDependencies": {
31-
"@aws-sdk/client-s3": "3.931.0",
32-
"@aws-sdk/client-ssm": "3.621.0",
31+
"@aws-sdk/client-s3": "3.991.0",
32+
"@aws-sdk/client-ssm": "3.991.0",
3333
"@guardian/cdk": "62.0.1",
3434
"@guardian/eslint-config": "12.0.1",
3535
"@guardian/tsconfig": "1.0.1",

ab-testing/deploy-lambda/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -12,8 +12,8 @@
1212
"prettier:fix": "prettier . --write --cache"
1313
},
1414
"dependencies": {
15-
"@aws-sdk/client-s3": "3.981.0",
16-
"@aws-sdk/client-ssm": "3.981.0",
15+
"@aws-sdk/client-s3": "3.991.0",
16+
"@aws-sdk/client-ssm": "3.991.0",
1717
"@guardian/ab-testing-config": "workspace:ab-testing-config",
1818
"superstruct": "2.0.2"
1919
},
Lines changed: 14 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,14 @@
1+
<script lang="ts">
2+
interface Props {
3+
testName: string;
4+
}
5+
6+
const { testName }: Props = $props();
7+
</script>
8+
9+
<a
10+
href={`https://metrics.gutools.co.uk/d/bfd4abner943ke/page-views?folderUid=efd48ip6ch3i8f&orgId=1&from=now-7d&to=now&var-test_name=${testName}`}
11+
target="_blank"
12+
>
13+
Grafana
14+
</a>

ab-testing/frontend/src/lib/components/OphanLink.svelte

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,5 +10,5 @@
1010
href={`https://dashboard.ophan.co.uk/graph/breakdown?day=today&ab=${testName}`}
1111
target="_blank"
1212
>
13-
graph
13+
Ophan
1414
</a>

ab-testing/frontend/src/lib/components/TableFixed.svelte

Lines changed: 12 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,8 @@
11
<script lang="ts">
2-
import type { ABTest } from '../../../../types.js';
3-
import OphanLink from '$lib/components/OphanLink.svelte';
4-
import TestVariants from '$lib/components/TestVariants.svelte';
2+
import type { ABTest } from "../../../../types.js";
3+
import OphanLink from "$lib/components/OphanLink.svelte";
4+
import TestVariants from "$lib/components/TestVariants.svelte";
5+
import GrafanaLink from "./GrafanaLink.svelte";
56
67
interface Props {
78
tests: ABTest[];
@@ -39,7 +40,7 @@
3940
<th scope="col">Test Groups</th>
4041
<th scope="col">Expires In</th>
4142
<th scope="col">Audience</th>
42-
<th scope="col">Ophan</th>
43+
<th scope="col">Page Views</th>
4344
</tr>
4445
</thead>
4546
<tbody>
@@ -49,7 +50,7 @@
4950
>
5051
<td
5152
class="status"
52-
class:off={test.status === 'OFF'}
53+
class:off={test.status === "OFF"}
5354
class:expired
5455
>
5556
{#if expired}
@@ -69,7 +70,11 @@
6970
>{daysToExpiry(test.expirationDate)} days</td
7071
>
7172
<td>{test.audienceSize * 100}%</td>
72-
<td><OphanLink testName={test.name} /></td>
73+
<td>
74+
<GrafanaLink testName={test.name} /> | <OphanLink
75+
testName={test.name}
76+
/>
77+
</td>
7378
</tr>
7479
<tr>
7580
<th scope="row">Description</th>
@@ -106,7 +111,7 @@
106111
padding: 8px;
107112
}
108113
109-
th[scope='col'] {
114+
th[scope="col"] {
110115
background-color: var(--light-grey);
111116
}
112117

ab-testing/notification-lambda/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,8 +13,8 @@
1313
"prettier:fix": "prettier . --write --cache"
1414
},
1515
"dependencies": {
16-
"@aws-sdk/client-ses": "3.981.0",
17-
"@aws-sdk/credential-providers": "3.981.0",
16+
"@aws-sdk/client-ses": "3.991.0",
17+
"@aws-sdk/credential-providers": "3.991.0",
1818
"@guardian/ab-testing-config": "workspace:ab-testing-config"
1919
},
2020
"devDependencies": {

dotcom-rendering/fixtures/manual/footballMatches.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ const matchData = {
1717
},
1818
leg: '1',
1919
homeTeam: {
20-
id: '1',
20+
id: '44',
2121
name: 'Home Team',
2222
},
2323
awayTeam: {
@@ -66,7 +66,7 @@ export const matchDayLive: FEMatchDay = {
6666
},
6767
awayTeam: {
6868
...matchData.awayTeam,
69-
score: 3,
69+
score: 4,
7070
},
7171
};
7272

dotcom-rendering/package.json

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
"build-storybook": "storybook build"
2020
},
2121
"dependencies": {
22-
"@aws-sdk/client-cloudwatch": "3.981.0",
22+
"@aws-sdk/client-cloudwatch": "3.991.0",
2323
"@babel/helper-compilation-targets": "7.28.6",
2424
"@braze/web-sdk": "5.8.1",
2525
"@creditkarma/thrift-server-core": "1.0.4",
@@ -88,7 +88,7 @@
8888
"@types/webpack-env": "1.18.8",
8989
"@types/webpack-node-externals": "3.0.4",
9090
"@types/youtube": "0.0.50",
91-
"ajv": "8.17.1",
91+
"ajv": "8.18.0",
9292
"ajv-formats": "2.1.1",
9393
"aws-cdk": "2.1030.0",
9494
"aws-cdk-lib": "2.220.0",

0 commit comments

Comments
 (0)