Skip to content

Commit 727ac9d

Browse files
committed
Expand name of test to future-proof us when we test articles using same test
1 parent 782bb12 commit 727ac9d

3 files changed

Lines changed: 12 additions & 13 deletions

File tree

ab-testing/config/abTests.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -196,8 +196,8 @@ const ABTests: ABTest[] = [
196196
shouldForceMetricsCollection: false,
197197
},
198198
{
199-
name: "fronts-and-curation-editorial-headline-test",
200-
description: "Allow editorial headline A/B tests to run on web",
199+
name: "fronts-and-curation-editorial-test",
200+
description: "Allow editorial A/B tests to run on web",
201201
owners: [
202202
"fronts.and.curation@guardian.co.uk",
203203
"ab.test.mission@guardian.co.uk",

dotcom-rendering/src/model/enhanceCards.test.ts

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -678,7 +678,7 @@ describe('Enhance Cards', () => {
678678
decideHeadline(
679679
cardWithNoEditorialTest,
680680
{
681-
'fronts-and-curation-editorial-headline-test': 'a',
681+
'fronts-and-curation-editorial-test': 'a',
682682
},
683683
true,
684684
'test-front',
@@ -691,7 +691,7 @@ describe('Enhance Cards', () => {
691691
decideHeadline(
692692
cardWithEditorialTest,
693693
{
694-
'fronts-and-curation-editorial-headline-test': 'a',
694+
'fronts-and-curation-editorial-test': 'a',
695695
},
696696
true,
697697
'invalid-test-front',
@@ -704,7 +704,7 @@ describe('Enhance Cards', () => {
704704
decideHeadline(
705705
cardWithEditorialTest,
706706
{
707-
'fronts-and-curation-editorial-headline-test': 'a',
707+
'fronts-and-curation-editorial-test': 'a',
708708
},
709709
false,
710710
'test-front',
@@ -717,7 +717,7 @@ describe('Enhance Cards', () => {
717717
decideHeadline(
718718
cardWithEditorialTest,
719719
{
720-
'fronts-and-curation-editorial-headline-test': 'a',
720+
'fronts-and-curation-editorial-test': 'a',
721721
},
722722
true,
723723
'test-front',
@@ -730,7 +730,7 @@ describe('Enhance Cards', () => {
730730
decideHeadline(
731731
cardWithEditorialTest,
732732
{
733-
'fronts-and-curation-editorial-headline-test': 'b',
733+
'fronts-and-curation-editorial-test': 'b',
734734
},
735735
true,
736736
'test-front',
@@ -743,7 +743,7 @@ describe('Enhance Cards', () => {
743743
decideHeadline(
744744
cardWithEditorialTest,
745745
{
746-
'fronts-and-curation-editorial-headline-test': 'c',
746+
'fronts-and-curation-editorial-test': 'c',
747747
},
748748
true,
749749
'test-front',
@@ -756,7 +756,7 @@ describe('Enhance Cards', () => {
756756
decideHeadline(
757757
cardWithEditorialTestWithUndefinedVariantMeta,
758758
{
759-
'fronts-and-curation-editorial-headline-test': 'a',
759+
'fronts-and-curation-editorial-test': 'a',
760760
},
761761
true,
762762
'test-front',
@@ -769,7 +769,7 @@ describe('Enhance Cards', () => {
769769
decideHeadline(
770770
cardWithExpiredEditorialTest,
771771
{
772-
'fronts-and-curation-editorial-headline-test': 'a',
772+
'fronts-and-curation-editorial-test': 'a',
773773
},
774774
true,
775775
'test-front',
@@ -782,7 +782,7 @@ describe('Enhance Cards', () => {
782782
decideHeadline(
783783
cardWithManuallyEndedEditorialTest,
784784
{
785-
'fronts-and-curation-editorial-headline-test': 'a',
785+
'fronts-and-curation-editorial-test': 'a',
786786
},
787787
true,
788788
'test-front',

dotcom-rendering/src/model/enhanceCards.ts

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -216,8 +216,7 @@ export const decideHeadline = (
216216
): string => {
217217
const defaultHeadline = faciaCard.header.headline;
218218

219-
const testBucket =
220-
serverSideABTests['fronts-and-curation-editorial-headline-test'];
219+
const testBucket = serverSideABTests['fronts-and-curation-editorial-test'];
221220

222221
const activeEditorialTest = findActiveEditorialTest(
223222
faciaCard.properties.tests,

0 commit comments

Comments
 (0)