Skip to content

Commit 945a074

Browse files
committed
Change additionalSizes for article-end header bidding integration and add 0% test
1 parent 3f450c8 commit 945a074

2 files changed

Lines changed: 19 additions & 4 deletions

File tree

ab-testing/config/abTests.ts

Lines changed: 13 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -251,6 +251,19 @@ const ABTests: ABTest[] = [
251251
],
252252
shouldForceMetricsCollection: true,
253253
},
254+
{
255+
name: "commercial-article-end-header-bidding",
256+
description:
257+
"Test opening up the article-end ad slot in the US region for HeaderBidding",
258+
owners: ["commercial.dev@guardian.co.uk"],
259+
expirationDate: "2026-10-01",
260+
type: "client",
261+
status: "ON",
262+
audienceSize: 0 / 100,
263+
audienceSpace: "B",
264+
groups: ["control", "variant"],
265+
shouldForceMetricsCollection: true,
266+
},
254267
];
255268

256269
const activeABtests = ABTests.filter((test) => test.status === "ON");

dotcom-rendering/src/components/SlotBodyEnd.island.tsx

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,7 @@ type Props = {
5656

5757
const slotStyles = css`
5858
color: ${palette.neutral[7]};
59+
margin: 12px auto;
5960
`;
6061

6162
const buildReaderRevenueEpicConfig = (
@@ -130,10 +131,9 @@ export const SlotBodyEnd = ({
130131
const [asyncArticleCount, setAsyncArticleCount] =
131132
useState<Promise<WeeklyArticleHistory | undefined>>();
132133

133-
const showPublicGood = countryCode === 'US';
134+
const isInUS = countryCode === 'US';
134135

135-
const showArticleEndSlot =
136-
renderAds && !isLabs && showPublicGood && articleEndSlot;
136+
const showArticleEndSlot = renderAds && !isLabs && isInUS && articleEndSlot;
137137

138138
useEffect(() => {
139139
setAsyncArticleCount(
@@ -238,7 +238,9 @@ export const SlotBodyEnd = ({
238238
new CustomEvent('gu.commercial.slot.fill', {
239239
detail: {
240240
slotId: 'dfp-ad--article-end',
241-
additionalSizes: { mobile: [adSizes.fluid] }, // Public Good additional ad slot sizes
241+
additionalSizes: {
242+
mobile: [adSizes.mpu],
243+
},
242244
},
243245
}),
244246
);

0 commit comments

Comments
 (0)