Replace assert.ok with shorter plain assert as they are equivalent

Author: arelra

dotcom-rendering/src/lib/affiliateLinksUtils.node.test.ts

@@ -70,11 +70,11 @@ void describe('buildXcustValueForAffiliateLink', () => {
 			xcustComponentId: null,
 		});
 
-		assert.ok(xcustResult.includes('|abTestParticipations|'));
-		assert.ok(xcustResult.includes('existingTest:control'));
-		assert.ok(xcustResult.includes('newTest:variantB'));
-		assert.ok(xcustResult.includes('abTest1:oldVariant'));
-		assert.ok(!xcustResult.includes('abTest1:variantA'));
+		assert(xcustResult.includes('|abTestParticipations|'));
+		assert(xcustResult.includes('existingTest:control'));
+		assert(xcustResult.includes('newTest:variantB'));
+		assert(xcustResult.includes('abTest1:oldVariant'));
+		assert(!xcustResult.includes('abTest1:variantA'));
 	});
 
 	void it('preserves existing AB participations when url already has xcust', () => {
@@ -88,11 +88,11 @@ void describe('buildXcustValueForAffiliateLink', () => {
 			xcustComponentId: null,
 		});
 
-		assert.ok(
+		assert(
 			xcustResult.includes('referrer|www.theguardian.com|accountId|1111'),
 		);
-		assert.ok(xcustResult.includes('newTest:newVariant'));
-		assert.ok(xcustResult.includes('oldTest:oldVariant'));
+		assert(xcustResult.includes('newTest:newVariant'));
+		assert(xcustResult.includes('oldTest:oldVariant'));
 	});
 });
 

dotcom-rendering/src/lib/getFrontsAdPositions.node.test.ts

@@ -43,7 +43,7 @@ void describe('Mobile Ads', () => {
 
 		const mobileAdPositions = getMobileAdPositions(testCollections, 'uk');
 
-		assert.ok(!mobileAdPositions.includes(0));
+		assert(!mobileAdPositions.includes(0));
 	});
 
 	void it(`should not insert an ad in the merchandising-high position`, () => {
@@ -52,7 +52,7 @@ void describe('Mobile Ads', () => {
 			{ ...testCollection, collectionType: 'news/most-popular' },
 		] satisfies AdCandidate[];
 		const mobileAdPositions = getMobileAdPositions(testCollections, 'uk');
-		assert.ok(!mobileAdPositions.includes(3));
+		assert(!mobileAdPositions.includes(3));
 	});
 
 	void it('Should not insert ad before a thrasher container', () => {
@@ -68,8 +68,8 @@ void describe('Mobile Ads', () => {
 
 		const mobileAdPositions = getMobileAdPositions(testCollections, 'uk');
 
-		assert.ok(!mobileAdPositions.includes(6));
-		assert.ok(!mobileAdPositions.includes(8));
+		assert(!mobileAdPositions.includes(6));
+		assert(!mobileAdPositions.includes(8));
 	});
 
 	void it(`Should allow inserting an ad before a thrasher container if it's a filter page`, () => {
@@ -88,8 +88,8 @@ void describe('Mobile Ads', () => {
 			'uk/thefilter',
 		);
 
-		assert.ok(mobileAdPositions.includes(6));
-		assert.ok(mobileAdPositions.includes(8));
+		assert(mobileAdPositions.includes(6));
+		assert(mobileAdPositions.includes(8));
 	});
 
 	// We used https://www.theguardian.com/uk/commentisfree as a blueprint
@@ -429,8 +429,8 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(adPositions.includes(0));
-			assert.ok(!adPositions.includes(1));
+			assert(adPositions.includes(0));
+			assert(!adPositions.includes(1));
 		});
 
 		void it('inserts an ad after the first collection if it is a LARGE flexible special container', () => {
@@ -451,8 +451,8 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(adPositions.includes(0));
-			assert.ok(!adPositions.includes(1));
+			assert(adPositions.includes(0));
+			assert(!adPositions.includes(1));
 		});
 
 		void it('does NOT insert an ad after the first collection if it is a SMALL flexible general container', () => {
@@ -468,7 +468,7 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(!adPositions.includes(0));
+			assert(!adPositions.includes(0));
 		});
 
 		void it('does NOT insert an ad after the first collection if it is a SMALL flexible special container', () => {
@@ -484,7 +484,7 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(!adPositions.includes(0));
+			assert(!adPositions.includes(0));
 		});
 	});
 
@@ -507,8 +507,8 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(adPositions.includes(1));
-			assert.ok(!adPositions.includes(2));
+			assert(adPositions.includes(1));
+			assert(!adPositions.includes(2));
 		});
 
 		void it('inserts an ad before the second collection if it is preceded by a LARGE flexible special container', () => {
@@ -529,8 +529,8 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(adPositions.includes(1));
-			assert.ok(!adPositions.includes(2));
+			assert(adPositions.includes(1));
+			assert(!adPositions.includes(2));
 		});
 
 		void it('does NOT insert an ad before the second collection if it is preceded by a SMALL flexible general container', () => {
@@ -551,7 +551,7 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(!adPositions.includes(1));
+			assert(!adPositions.includes(1));
 		});
 
 		void it('does NOT insert an ad before the second collection if it is preceded by a SMALL flexible special container', () => {
@@ -572,7 +572,7 @@ void describe('inserting an ad after the first collection', () => {
 				'uk',
 			);
 
-			assert.ok(!adPositions.includes(1));
+			assert(!adPositions.includes(1));
 		});
 	});
 });

dotcom-rendering/src/lib/getZIndex.node.test.ts

@@ -4,18 +4,18 @@ import { getZIndex } from './getZIndex';
 
 void describe('getZIndex', () => {
 	void it('gets the correct zindex for group and sibling', () => {
-		assert.ok(getZIndex('sticky-video-button') > getZIndex('sticky-video'));
-		assert.ok(
+		assert(getZIndex('sticky-video-button') > getZIndex('sticky-video'));
+		assert(
 			getZIndex('expanded-veggie-menu-wrapper') >
 				getZIndex('expanded-veggie-menu'),
 		);
-		assert.ok(
+		assert(
 			getZIndex('stickyAdWrapperLabsHeader') >
 				getZIndex('stickyAdWrapper'),
 		);
-		assert.ok(getZIndex('tableOfContents') > getZIndex('articleHeadline'));
-		assert.ok(getZIndex('subNavBanner') > getZIndex('articleHeadline'));
-		assert.ok(getZIndex('subNavBanner') > getZIndex('bodyArea'));
-		assert.ok(getZIndex('card-nested-link') > getZIndex('card-link'));
+		assert(getZIndex('tableOfContents') > getZIndex('articleHeadline'));
+		assert(getZIndex('subNavBanner') > getZIndex('articleHeadline'));
+		assert(getZIndex('subNavBanner') > getZIndex('bodyArea'));
+		assert(getZIndex('card-nested-link') > getZIndex('card-link'));
 	});
 });

dotcom-rendering/src/lib/liveblogAdSlots.node.test.ts

@@ -157,7 +157,7 @@ void describe('shouldDisplayAd', () => {
 					isMobile,
 				);
 
-				assert.ok(!result);
+				assert(!result);
 			});
 		}
 	});
@@ -179,7 +179,7 @@ void describe('shouldDisplayAd', () => {
 					isMobile,
 				);
 
-				assert.ok(!result);
+				assert(!result);
 			});
 		}
 	});
@@ -201,7 +201,7 @@ void describe('shouldDisplayAd', () => {
 					isMobile,
 				);
 
-				assert.ok(result);
+				assert(result);
 			});
 		}
 	});
@@ -226,7 +226,7 @@ void describe('shouldDisplayAd', () => {
 					isMobile,
 				);
 
-				assert.ok(result);
+				assert(result);
 			});
 		}
 
@@ -249,7 +249,7 @@ void describe('shouldDisplayAd', () => {
 					isMobile,
 				);
 
-				assert.ok(!result);
+				assert(!result);
 			});
 		}
 	});

dotcom-rendering/src/model/enhance-ad-placeholders.node.test.ts

@@ -311,7 +311,7 @@ void describe('enhanceAdPlaceholders', () => {
 			)(input);
 			const outputPlaceholders = output.filter(elementIsAdPlaceholder);
 
-			assert.ok(outputPlaceholders.length > 0);
+			assert(outputPlaceholders.length > 0);
 		});
 	});
 });

dotcom-rendering/src/model/enhanceCommercialProperties.node.test.ts

@@ -46,14 +46,14 @@ void describe('Enhance Branding', () => {
 			.map((p) => p.branding?.logo.dimensions.width)
 			.filter(isNumber);
 
-		assert.ok(Math.max(...dimensionsFail) > 140);
+		assert(Math.max(...dimensionsFail) > 140);
 
 		const dimensionsPass = Object.values(
 			enhanceCommercialProperties(commercialProperties),
 		)
 			.map((p) => p.branding?.logo.dimensions.width)
 			.filter(isNumber);
 
-		assert.ok(Math.max(...dimensionsPass) <= 140);
+		assert(Math.max(...dimensionsPass) <= 140);
 	});
 });

dotcom-rendering/src/model/unwrapHtml.node.test.ts

@@ -34,9 +34,9 @@ void describe('unwrapHtml', () => {
 			unwrapHtml(pUnwrap);
 
 		// Testy test
-		assert.ok(bqIsUnwrapped);
+		assert(bqIsUnwrapped);
 		assert.equal(bqUnwrappedHtml, '<p>inner</p>');
-		assert.ok(pIsUnwrapped);
+		assert(pIsUnwrapped);
 		assert.equal(pUnwrappedHtml, 'inner');
 	});
 
@@ -52,7 +52,7 @@ void describe('unwrapHtml', () => {
 		};
 		const { willUnwrap: isUnwrapped, unwrappedHtml } = unwrapHtml(bqUnwrap);
 
-		assert.ok(!isUnwrapped);
+		assert(!isUnwrapped);
 		assert.equal(unwrappedHtml, bqUnwrap.html);
 	});
 
@@ -123,15 +123,15 @@ void describe('unwrapHtml', () => {
 			unwrappedElement: ulUnwrappedElement,
 		} = unwrapHtml(ulUnwrap);
 
-		assert.ok(bqIsUnwrapped);
+		assert(bqIsUnwrapped);
 		assert.equal(bqUnwrappedHtml, '<p>inner</p>');
 		assert.equal(bqUnwrappedElement, 'blockquote');
 
-		assert.ok(pIsUnwrapped);
+		assert(pIsUnwrapped);
 		assert.equal(pUnwrappedHtml, 'inner');
 		assert.equal(pUnwrappedElement, 'p');
 
-		assert.ok(ulIsUnwrapped);
+		assert(ulIsUnwrapped);
 		assert.equal(ulUnwrappedHtml, '<li>Test</li><li>test2</li>');
 		assert.equal(ulUnwrappedElement, 'ul');
 	});