Skip to content

Implement interactive URL darkmode fix for additional path groups #13756

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
KaliedaRik merged 2 commits into from
Apr 9, 2025
Merged

Implement interactive URL darkmode fix for additional path groups #13756

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d48d022
Implement interactive URL darkmode fix for additional path groups
RikRootsGuardian Apr 8, 2025
1df5a7f
Merge branch 'main' into rjr-interactive-url-additional-darkmode-fix
RikRootsGuardian Apr 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion dotcom-rendering/src/components/InteractiveBlockComponent.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -334,7 +334,10 @@ export const InteractiveBlockComponent = ({
: false;

const isUploaderEmbedPath =
url && url.includes('interactive.guim.co.uk/uploader/embed/')
url &&
(url.includes('interactive.guim.co.uk/uploader/embed/') ||
url.includes('superyacht') ||

@simonbyford simonbyford Apr 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could this be a more suitable (i.e. less general) marker?

Suggested change
url.includes('superyacht') ||
url.includes('interactive.guim.co.uk/embed/superyacht') ||

We'd just have to be sure all superyacht URLs have this form

@KaliedaRik KaliedaRik Apr 9, 2025

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the last audit test I ran I managed to catch 118 superyacht URLs, which is the same number you get when you search that sheet for interactive.guim.co.uk/embed/superyacht - which gives me some confidence that the tool has been set up to always dump its output into the same S3 bucket. https://docs.google.com/spreadsheets/d/1DF-6cBa5xQCH_1tKgc7x5F5eXakQYKz00IbMjywwjO0/edit?gid=1748685808#gid=1748685808

@simonbyford simonbyford Apr 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That sounds promising. Shall we make the change?

@simonbyford simonbyford Apr 9, 2025

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I see, you're making the opposite argument.

Sure, I'm fine to leave it as superyacht 👍

url.includes('choropleth_map_maker'))
? true
: false;

Expand Down
Loading