Rejig interactives disableArticleSwipe implementation - #14112
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Size Change: +57 B (+0.01%) Total Size: 1.05 MB ℹ️ View Unchanged
|
github-actions
Bot
removed
the
run_chromatic
marjisound
reviewed
Jun 20, 2025
| .catch((error) => { | ||
| log('dotcom', 'disableArticleSwipe(false) failed', error); | ||
| }); | ||
| }; |
Contributor
There was a problem hiding this comment.
I'm wondering if you want the article to always have the article swipe disabled? If that's the case, it might be better to not ever set this to true, what do you think?
Contributor
Author
There was a problem hiding this comment.
Ah that's a great shout! Yes, we always want interactives to have the article swipe disabled, have removed touchend events with bd01f1c
| document.removeEventListener('touchend', onTouchEnd); | ||
| }; | ||
| }, []); | ||
| return null; |
Contributor
There was a problem hiding this comment.
Also wondering if you tested the number of events that are being fired. I think this might cause too many events being fired and might have performance side effect. I'm not sure though, it needs testing
Contributor
Author
There was a problem hiding this comment.
I haven't, it's tricky to get things in the emulators pre-beta, though it shouldn't fire any more than carousels or key events on live blogs should it? A blanket on/off switch would be ideal but my understanding is that's not how the Android implementation works
Contributor
There was a problem hiding this comment.
I will setup my android simulator now and will test this. Will let you know 👍
github-actions
Bot
removed
the
run_chromatic
marjisound
approved these changes
Jun 20, 2025
|
Seen on PROD (merged by @frederickobrien 8 minutes and 53 seconds ago) Please check your changes! |
marjisound
pushed a commit
that referenced
this pull request
Jun 20, 2025
This was referenced Jun 25, 2025
groakland
added
maintenance
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adjusts the what was implemented in #14111 to be more akin to other uses of the same function i.e. having
onTouchStartandonTouchEndevents run constantly.Documentation over in the Android app suggests that the Bridget function only locks the next swipe event. That being the case it needs to run on every interaction rather than once when the page loads.
Now I think of it this is also safer in the sense that if someone were to interact with a carousel on an interactives article, with the prior approach it would then be left turned on!