Gallery main media: constrain lightbox overlay - #14535
Merged
Merged
Conversation
DanielCliftonGuardian
added
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
DanielCliftonGuardian
changed the title
DanielCliftonGuardian
added
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
DanielCliftonGuardian
marked this pull request as ready for review
September 19, 2025 16:18
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
DanielCliftonGuardian
marked this pull request as draft
September 22, 2025 09:45
DanielCliftonGuardian
marked this pull request as ready for review
September 22, 2025 11:13
DanielCliftonGuardian
added
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
arelra
reviewed
Sep 22, 2025
DanielCliftonGuardian
added
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
DanielCliftonGuardian
added
the
run_chromatic
github-actions
Bot
removed
the
run_chromatic
arelra
approved these changes
Sep 22, 2025
|
Seen on PROD (merged by @DanielCliftonGuardian 8 minutes and 6 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds
position: relativeto the main media gallery figure so the LightboxLink overlay is confined to the image. Adds a stacking context for Gallery main media (position: relative; z-index: 0) and elevates the Gallery headline (z-index: 2) to preserve headline over image overlap.Why?
Prevents the lightbox click area extending over the masthead.
Resolves #14521