Skip to content

Add Sponsored Content Label - #14549

Merged
on-ye merged 3 commits into
mainfrom
feat/sponsored-content-label
Sep 23, 2025
Merged

on-ye merged 3 commits into
mainfrom
feat/sponsored-content-label

Conversation

@on-ye

@on-ye on-ye commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

What does this change?

Introduces a Sponsored Content Label for use within Labs content

Why?

Unifies the various implementations of this component into one standardised component

Testing

  • Run storybook from ./dotcom-rendering
  • Visit http://localhost:4002/?path=/story/components-sponsoredcontentlabel--horizontal-orientation

Screenshots

Horizontal Vertical Vertical right aligned
horizontal vertical verticalr

@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@on-ye
on-ye force-pushed the feat/sponsored-content-label branch from f15677a to 687fa35 Compare September 23, 2025 10:03
@github-actions

github-actions Bot commented Sep 23, 2025

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Sep 23, 2025

Copy link
Copy Markdown

@cemms1
cemms1 requested a review from a team September 23, 2025 10:07

@cemms1 cemms1 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👏 so neat!

Comment on lines +29 to +37
const verticalStyles = {
start: css`
flex-direction: column;
`,
end: css`
align-items: end;
flex-direction: column;
`,
};

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is smart!

Comment thread dotcom-rendering/src/components/SponsoredContentLabel.tsx Outdated
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@cemms1 cemms1 added the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 23, 2025
@cemms1

cemms1 commented Sep 23, 2025

Copy link
Copy Markdown
Contributor

@on-ye I just added the "run chromatic" label for you on this PR. You need to manually add it to get the workflow to run. You'll need to approve any diffs flagged up by Chromatic before merging

@on-ye
on-ye merged commit 3c623cb into main Sep 23, 2025
31 checks passed
@on-ye
on-ye deleted the feat/sponsored-content-label branch September 23, 2025 10:52
@gu-prout

gu-prout Bot commented Sep 23, 2025

Copy link
Copy Markdown

Seen on PROD (merged by @on-ye 7 minutes and 52 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants