Replace serverTime prop with context - #15120
Closed
jamesmockett wants to merge 5 commits into
Closed
jamesmockett wants to merge 5 commits into
jamesmockett wants to merge 5 commits into
Conversation
jamesmockett
added
the
maintenance
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
jamesmockett
force-pushed
the
jm/server-time-context
branch
from
February 13, 2026 17:23
6300eed to
d6897ec
Compare
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Removes
serverTimeprop (used to prop drill current date and time down to theDateTimecomponent) and moves to context insteadWhy?
This prop adds a lot of extra noise to the codebase due to having to be drilled through numerous components so it is available where needed. We also found it difficult to make the prop required (#14776) as in some cases the data is not easily available (ie. when doing partial rendering of components).
DateTimealready relies on context fromConfigProviderso by also includingDateTimeProviderwherever this is used we can ensure that it is available where needed.