Revert banner:none event dispatch - #15349
Closed
dskamiotis wants to merge 1 commit into
Closed
dskamiotis wants to merge 1 commit into
dskamiotis wants to merge 1 commit into
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
dskamiotis
force-pushed
the
ds/check-pre-banner-close-and-none-event-change
branch
from
February 12, 2026 17:31
199761e to
7620299
Compare
dskamiotis
added
feature
dskamiotis
force-pushed
the
ds/check-pre-banner-close-and-none-event-change
branch
from
February 12, 2026 17:47
7620299 to
c666048
Compare
github-actions
Bot
removed
the
run_chromatic
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Gates the banner:none event dispatch behind a 0% A/B test (commercial-banner-ad-coordination) using the new beta AB testing framework.
The event logic is preserved but disabled. Uses useBetaAB() to check if users are in the test variant before dispatching events.
Why?
The CMP banner currently blocks mobile sticky ads even though it renders "outside of react's world" and doesn't occupy the banner space. This may be causing incorrect ad suppression and impacts revenue.
By gating behind a 0% test, we:
Related to: guardian/commercial#2351