Football match header polling - #15350
Merged
Merged
Conversation
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com> Co-authored-by: James Mockett <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com> Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com> Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com> Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com> Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com> Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com> Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
`FootballMatchHeader` is also now wrapped inside an `Island` so the client side fetch is functional Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
The side-effectful fetch function is now passed in, which means we can pass a mock version in storybook for testing. Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com> Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
Co-authored-by: James M <1166188+jamesmockett@users.noreply.github.com>
jamesmockett
force-pushed
the
add-polling-for-match-header
branch
from
February 12, 2026 17:51
b33ba47 to
866003d
Compare
github-actions
Bot
removed
the
run_chromatic
As the before and after state for the 'Fixture' story is the same the expectations will pass before the UI has updated as `waitFor` does not have to wait and retry. By awaiting the change to the team name we ensure the UI has actually been updated before testing it is correct.
marjisound
approved these changes
Feb 16, 2026
github-actions
Bot
removed
the
run_chromatic
|
Seen on PROD (merged by @jamesmockett 7 minutes and 41 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Paired with @JamieB-gu, @jamesmockett & @marjisound
What does this change?
Adds polling to football match header
FootballMatchHeader.importablewrapper component.FootballMatchHeader.importableand passed as a prop to the childFootballMatchHeadercomponent. This allows the data fetching to be mocked and tested in Storybook.Why?
To update the header in realtime to reflect the current state of the match
Screenshots