Add carousel aria attributes to highlights container - #15389
Merged
Merged
Conversation
domlander
commented
Feb 18, 2026
| size="small" | ||
| disabled={!previousButtonEnabled} | ||
| aria-label="View next image in slideshow" | ||
| aria-label="Previous image" |
Contributor
Author
There was a problem hiding this comment.
These were the wrong way around
Contributor
Author
There was a problem hiding this comment.
We don't need "slideshow" any more, now that the user will know they are inside a slideshow following #15365
domlander
commented
Feb 18, 2026
| aria-label="Highlights" | ||
| aria-live="polite" | ||
| > | ||
| <ul |
Contributor
Author
There was a problem hiding this comment.
I think an unordered list makes more sense here. Google seem to prefer it.
Member
There was a problem hiding this comment.
domlander
added
run_chromatic
domlander
marked this pull request as ready for review
February 18, 2026 16:03
domlander
changed the title
github-actions
Bot
removed
the
run_chromatic
arelra
approved these changes
Feb 18, 2026
|
Seen on PROD (merged by @domlander 8 minutes ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Adds aria attributes to the Slideshow Carousel component.
Why?
Better accessibility when using a screen reader.
Extends #15365
Screenshares
Before
Screen.Recording.2026-02-18.at.15.44.45.mov
After
Screen.Recording.2026-02-18.at.15.43.16.mov