Skip to content

Add carousel aria attributes to highlights container #15389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
domlander merged 2 commits into from
Feb 18, 2026
Merged

Add carousel aria attributes to highlights container #15389

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9af466d
Add carousel attributes to highlights container
domlander Feb 18, 2026
a8663eb
Merge branch 'main' into doml/highlights-carousel-accessibility
domlander Feb 18, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions dotcom-rendering/src/components/Card/Card.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ export type Props = {
/** The index of the card in a carousel */
index?: number;
/**
* Useful for videos. Has the form: collection-{collection ID}-{card grouping type}-{card index}
* Useful for IDs. Has the form: collection-{collection ID}-{card grouping type}-{card index}
* For example, the first splash card in the second collection would be: "collection-1-splash-0"
*/
uniqueId?: string;
Expand All @@ -152,7 +152,7 @@ export type Props = {
showTopBarDesktop?: boolean;
showTopBarMobile?: boolean;
trailTextSize?: TrailTextSize;
/** A kicker image is seperate to the main media and renders as part of the kicker */
/** A kicker image is separate to the main media and renders as part of the kicker */
showKickerImage?: boolean;
subtitleSize?: SubtitleSize;
/** Determines if the headline should be positioned within the content or outside the content */
Expand Down
21 changes: 15 additions & 6 deletions dotcom-rendering/src/components/ScrollableHighlights.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -268,23 +268,32 @@ export const ScrollableHighlights = ({ trails, frontId }: Props) => {
getOphanInfo(frontId);

return (
<div css={containerStyles} data-link-name={ophanFrontName}>
<ol
data-link-name={ophanComponentLink}
data-component={ophanComponentName}
data-container-name={'scrollable/highlights'}
<div
css={containerStyles}
data-link-name={ophanFrontName}
role="region"
aria-roledescription="carousel"
aria-label="Highlights"
aria-live="polite"
>
<ul

@domlander domlander Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think an unordered list makes more sense here. Google seem to prefer it.

@arelra arelra Feb 18, 2026

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same here:
https://www.w3.org/WAI/tutorials/carousels/structure/

ref={carouselRef}
css={[
carouselStyles,
generateCarouselColumnStyles(carouselLength),
]}
data-link-name={ophanComponentLink}
data-component={ophanComponentName}
data-container-name="scrollable/highlights"
data-heatphan-type="carousel"
>
{trails.map((trail) => {
return (
<li
key={trail.url}
css={[itemStyles, verticalLineStyles]}
role="group"
aria-roledescription="slide"
>
<HighlightsCard
format={trail.format}
Expand All @@ -304,7 +313,7 @@ export const ScrollableHighlights = ({ trails, frontId }: Props) => {
</li>
);
})}
</ol>
</ul>

<Hide until="tablet">
{showPreviousButton && (
Expand Down
4 changes: 2 additions & 2 deletions dotcom-rendering/src/components/SlideshowCarousel.importable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -291,7 +291,7 @@ export const SlideshowCarousel = ({
}
size="small"
disabled={!previousButtonEnabled}
aria-label="View next image in slideshow"
aria-label="Previous image"

@domlander domlander Feb 18, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These were the wrong way around

@domlander domlander Feb 18, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't need "slideshow" any more, now that the user will know they are inside a slideshow following #15365

// TODO: data-link-name="slideshow carousel left chevron"
/>

Expand All @@ -308,7 +308,7 @@ export const SlideshowCarousel = ({
}
size="small"
disabled={!nextButtonEnabled}
aria-label="View previous image in slideshow"
aria-label="Next image"
// TODO: data-link-name="slideshow carousel right chevron"
/>
</div>
Expand Down
Loading