Skip to content

overflowWrap: 'anywhere' for CardHeadlines - #16044

Closed
dblatcher wants to merge 413 commits into
mainfrom
dblatcher-overflowing-word-in-card-fix
Closed

dblatcher wants to merge 413 commits into
mainfrom
dblatcher-overflowing-word-in-card-fix

Conversation

@dblatcher

Copy link
Copy Markdown
Contributor

What does this change?

Applies overflowWrap: 'anywhere' the the h3 in CardHeadlines

Why?

Fixes an issue noted by CP.

Open https://www.theguardian.com/world/2026/jun/03/sixty-thousand-love-letters-germany-archive-volunteers (or http://localhost:3030/Article/https://www.theguardian.com/world/2026/jun/03/sixty-thousand-love-letters-germany-archive-volunteers
running local DCR) and look at the "related stories" - it included this article which has a 64 letter word that breaks the layout and makes the image bigger than it should be.

Screenshots

Before After
Screenshot 2026-06-03 at 14 52 22 Screenshot 2026-06-03 at 14 53 18

@dblatcher dblatcher added run_chromatic Runs chromatic when label is applied fix Departmental tracking: fix labels Jun 3, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown

@Jakeii Jakeii left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we've use break-word in similar situations: https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/ContainerTitle.tsx#L40

Also this is a great case for a story book story!

@paperboyo

Copy link
Copy Markdown
Contributor

Related: #14331 (comment)

@dblatcher

Copy link
Copy Markdown
Contributor Author

I think we've use break-word in similar situations: https://github.com/guardian/dotcom-rendering/blob/main/dotcom-rendering/src/components/ContainerTitle.tsx#L40

Also this is a great case for a story book story!

Unfortunately, overflow-wrap: break-word doesn't work in the (rather extreme) case:
Screenshot 2026-06-04 at 09 37 23
Screenshot 2026-06-04 at 09 37 36

Definitely agree adding a story would be a great idea - but I could do with some help figuring out where to put it so it covers all the relevant themes, variants and contexts.

@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown

marjisound and others added 22 commits June 16, 2026 09:28
…model

Update frontend cricket match data type to make it in sync with frontend
Update "Golden Boot" casing on the World Cup subnav
Link follow to notifications in article pages
* Couple isMuted initial state to preventAutoplay.

This is so that any click to play videos are unmuted by default. Otherwise, videos where autoplay is enabled are muted by default.

* Consider videoStyleSettings as well when determining if the video will attempt to autoplay
This is because in apps we can't use the ab testing
Signed-off-by: dependabot[bot] <support@github.com>
jonathonherbert and others added 16 commits July 8, 2026 14:01
…etermine-public-path

Revert "Use USE_LOCAL_ASSETS env var to determine path for assets"
Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
Co-authored-by: Alex D <3389563+alexduf@users.noreply.github.com>
Co-authored-by: williammead <285652121+williammead@users.noreply.github.com>
Co-authored-by: Peace Williams-Ojomu <60498278+apeacewilliams@users.noreply.github.com>
Co-authored-by: Jamie B <53781962+JamieB-gu@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
Co-authored-by: Alex D <3389563+alexduf@users.noreply.github.com>
Co-authored-by: williammead <285652121+williammead@users.noreply.github.com>
Co-authored-by: Peace Williams-Ojomu <60498278+apeacewilliams@users.noreply.github.com>
Co-authored-by: Marjan K <15894063+marjisound@users.noreply.github.com>
Co-authored-by: Alex D <3389563+alexduf@users.noreply.github.com>
Co-authored-by: Jake LK <1731150+Jakeii@users.noreply.github.com>
This reverts commit bfac6ab, reversing
changes made to d55fe31.
Within ECS, it is common to write logs to stdout/stderr and have a sidecar process the logs.
This change configures Log4JS for this. Note that there is only one appender, as it looks like the presence of a `fileAppender` causes Log4JS to attempt a `mkdir` which is currently restricted in our image.

See also #16341.
The aim here is to confirm the production image works before running on AWS ECS,
as its slightly easier to debug any issues locally.
fix: Correctly configure Log4JS when running in ECS
This changes CI in a significant way - the production image is now built and published as the first step (~2 minutes).
This is because we need to pass the image digest to CDK to inject into the CloudFormation template.
Update tag page rendering CODE to provision ECS infrastructure but route no traffic to it.
feat(cdk): Provision ECS infrastructure for tag page rendering CODE
Bumps [guardian/actions-riff-raff](https://github.com/guardian/actions-riff-raff) from 4.3.3 to 4.3.4.
- [Release notes](https://github.com/guardian/actions-riff-raff/releases)
- [Commits](guardian/actions-riff-raff@v4.3.3...v4.3.4)

---
updated-dependencies:
- dependency-name: guardian/actions-riff-raff
  dependency-version: 4.3.4
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <support@github.com>
@akash1810

akash1810 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Please rebase this branch against main before deploying to CODE. #16321 made some changes to CI and infrastructure. Deploying this branch without these changes present will either:

  • Fail when using Riff-Raff's default update strategy
  • OR delete the new infrastructure if using Riff-Raff's "dangerous" mode

Please rebase this branch against main before deploying to CODE.

@dblatcher
dblatcher requested review from a team as code owners July 9, 2026 14:03
@github-actions

github-actions Bot commented Aug 9, 2026

Copy link
Copy Markdown

"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days"

@github-actions github-actions Bot added the Stale label Aug 9, 2026
@github-actions

Copy link
Copy Markdown

This PR was closed because it has been stalled for 3 days with no activity.

@github-actions github-actions Bot closed this Aug 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

fix Departmental tracking: fix Stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.