Conversation
…ool and allow videos to render in article without these images.
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
|
Please rebase this branch against
Please rebase this branch against |
| export type Props = { | ||
| imageSize: MediaSizeType; | ||
| mainImage: string; | ||
| mainImage?: string; |
There was a problem hiding this comment.
It seems a little strong to make this prop optional to accommodate the video player. Semantically, I think it makes sense for the image prop of the CardPicture component to be mandatory. Can we instead leave this prop mandatory and only call this component if a poster/fallback image exists?
|
"This PR is stale because it has been open 30 days with no activity. Unless a comment is added or the “stale” label removed, this will be closed in 3 days" |
|
This PR was closed because it has been stalled for 3 days with no activity. |
4 participants
What does this change?
Make self hosted video poster image and fallback image optional
Why?
MAM does not require these fields so this better reflects the state of the atom in CAPI.
This also allows videos in articles to render if a poster image is not available. Previously, videos without a poster image in article returned null to handle the required type.
Screenshots