Skip to content

Update Labs immersive main media and typography - #16707

Merged
DanielCliftonGuardian merged 9 commits into
mainfrom
labs-immersive-updates
Sep 16, 2026
Merged

DanielCliftonGuardian merged 9 commits into
mainfrom
labs-immersive-updates

Conversation

@DanielCliftonGuardian

@DanielCliftonGuardian DanielCliftonGuardian commented Sep 9, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Make main media scale with a minimum height of 469px and centred cropping, while preserving desktop sizing and refines the fade gradient.

In line with figma feedback https://www.figma.com/design/EKAebPFSCP6uCe11gP19X7/Formats-%E2%80%94-Display-Hinting?node-id=3198-26064&p=f&t=WvArIOvUBuiBIo2m-0

Screenshots

Before / After

image image image

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Sep 9, 2026
@DanielCliftonGuardian DanielCliftonGuardian added maintenance Departmental tracking: maintenance work, not a fix or a feature run_chromatic Runs chromatic when label is applied labels Sep 9, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 9, 2026
@github-actions

github-actions Bot commented Sep 9, 2026

Copy link
Copy Markdown

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 10, 2026
@DanielCliftonGuardian
DanielCliftonGuardian marked this pull request as ready for review September 10, 2026 11:12
@github-actions

github-actions Bot commented Sep 10, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:b3874801cf00d2c4637b3c3ff04d51235b7e1caeaa261e767fde2db08d4e891a

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:b3874801cf00d2c4637b3c3ff04d51235b7e1caeaa261e767fde2db08d4e891a"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-labs-immersive-updates"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31161"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 10, 2026
@cemms1
cemms1 requested a review from a team September 10, 2026 16:42
Comment thread dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx Outdated
Comment thread dotcom-rendering/src/components/Standfirst.tsx Outdated
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 14, 2026
Comment thread dotcom-rendering/src/components/Standfirst.tsx Outdated
Comment thread dotcom-rendering/src/layouts/StandardLayoutArticleGrid.tsx
@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 15, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 15, 2026
@DanielCliftonGuardian
DanielCliftonGuardian added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 8616c02 Sep 16, 2026
38 checks passed
@DanielCliftonGuardian
DanielCliftonGuardian deleted the labs-immersive-updates branch September 16, 2026 11:12
@gu-prout

gu-prout Bot commented Sep 16, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @DanielCliftonGuardian 14 minutes and 31 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants