Add new variant to mobile above nav test - without the RR StickyBottomBanner - #16721
Open
oliverabrahams wants to merge 2 commits into
Open
oliverabrahams wants to merge 2 commits into
oliverabrahams wants to merge 2 commits into
Conversation
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Add focused tests covering variant2 suppression and crossword page boundaries.
Get a fresh assessment by requesting another Copilot review.
Pull request overview
Adds variant2 to the mobile above-nav experiment and suppresses the Reader Revenue banner for eligible crossword pages.
Changes:
- Enables
variant2for mobile above-nav adverts. - Suppresses RR banners on crossword pages and fronts.
- Updates experiment configuration and lockfile metadata.
File summaries
| File | Summary |
|---|---|
pnpm-lock.yaml |
Updates dependency resolution metadata. |
dotcom-rendering/src/lib/commercialMobileAboveNavTest.ts |
Defines eligible ad-slot variants. |
dotcom-rendering/src/layouts/FrontLayout.tsx |
Enables the mobile slot for both variants. |
dotcom-rendering/src/layouts/CrosswordLayout.tsx |
Enables the mobile slot for crossword articles. |
dotcom-rendering/src/components/StickyBottomBanner/ReaderRevenueBanner.tsx |
Suppresses RR banners for eligible pages. |
dotcom-rendering/src/components/StickyBottomBanner.island.tsx |
Passes experiment participation to RR logic. |
ab-testing/config/abTests.ts |
Adds variant2 to the experiment. |
Review details
Files not reviewed (1)
- pnpm-lock.yaml: Generated file
Suppressed comments (1)
dotcom-rendering/src/components/StickyBottomBanner/ReaderRevenueBanner.tsx:233
- This new suppression path is not covered by the existing tests:
StickyBottomBanner.island.test.tsxmockscanShowRRBanner, so it cannot verify thatvariant2suppresses RR only for Web crossword articles/fronts while control/variant, non-crossword pages, and Apps remain eligible. Add focused tests for these boundaries (including thetype/crosswordtag andcrosswordspage ID).
if (
inNoShowMobileAboveNavVariant === true &&
isInMobileAboveNavTest(tags, renderingTarget, pageId)
) {
return { show: false };
}
- Files reviewed: 6/7 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
# Conflicts: # pnpm-lock.yaml
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:d5915722a74150e50329280b315fa7d16bcc83f604cf8408fafa52db55d0d88b"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-oa-mobile-above-nav-variant-2"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31147"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
tomrf1
approved these changes
Sep 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Both variants are only for 2 types of pages.
https://github.com/guardian/content-api-scala-client/blob/ed83e958d5ebff2b3aa418dfeb2450236b68109c/client/src/main/scala/com.gu.contentapi.client/utils/CapiModelEnrichment.scala#L123
variant2which does not show the RR sticky bottom banner.Why?
We are going to run a test on this new ad slot #16691
We need to see what affect RR sticky bottom banner has on this new ad slot on mobile.