Skip to content

Fix advert overlap in Puzzles hub’s most-pop section - #16726

Merged
DanielCliftonGuardian merged 1 commit into
mainfrom
ad-overlap
Sep 16, 2026
Merged

DanielCliftonGuardian merged 1 commit into
mainfrom
ad-overlap

Conversation

@DanielCliftonGuardian

@DanielCliftonGuardian DanielCliftonGuardian commented Sep 15, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Replaces the absolutely positioned mostpop advert wrapper with an in-flow desktop grid column.

Why?

The shared mostpop slot supports 300×600 creatives. With absolute positioning, these taller adverts extended beyond the supporting section and overlapped the next banner.

This fixes the layout without changing GAM targeting or supported creative sizes.

How has this change been tested?

Screenshots

Before After
before after

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Sep 15, 2026
@DanielCliftonGuardian DanielCliftonGuardian added run_chromatic Runs chromatic when label is applied maintenance Departmental tracking: maintenance work, not a fix or a feature labels Sep 15, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 15, 2026
@DanielCliftonGuardian
DanielCliftonGuardian marked this pull request as ready for review September 15, 2026 11:54
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@gustavo-olmedo gustavo-olmedo left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@DanielCliftonGuardian
DanielCliftonGuardian added this pull request to the merge queue Sep 16, 2026
Merged via the queue into main with commit 7120f05 Sep 16, 2026
38 of 41 checks passed
@DanielCliftonGuardian
DanielCliftonGuardian deleted the ad-overlap branch September 16, 2026 11:11
@gu-prout

gu-prout Bot commented Sep 16, 2026

Copy link
Copy Markdown

Seen on PROD (merged by @DanielCliftonGuardian 10 minutes and 8 seconds ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature Seen-on-PROD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants