Rename editorial test types and functions - #16728
Merged
Merged
Conversation
emma-imber
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
github-actions
Bot
removed
the
run_chromatic
abeddow91
approved these changes
Sep 16, 2026
abeddow91
left a comment
abeddow91
left a comment
Contributor
There was a problem hiding this comment.
lovely and tidy 🧹 this should help reduce any confusion when article ab tests are rolled out
|
Seen on PROD (merged by @emma-imber 8 minutes and 25 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Renames the
EditorialTesttype, and similarly named functions inenhanceCardsto addFrontto the name.Why?
Follows on from this comment, to rename the functions and types for fronts testing more specifically. Now that the team is working on Article AB testing, we want to make the naming of this code more specific to avoid confusion with future Article testing logic.