Puzzles/Polish the Puzzles and Games hub responsive layout - #16734
Merged
gustavo-olmedo merged 18 commits intoSep 16, 2026
Merged
Conversation
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:fe2ce482e2c7167cd25701a0e3d268b031c9fc05d473e304bd3f0f09d2f4207b"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-puzzles-images-sizing-accesibility-setters"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31203"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
andresilva-guardian
approved these changes
Sep 16, 2026
gustavo-olmedo
deleted the
puzzles/images-sizing-accesibility-setters
branch
September 16, 2026 11:53
|
Seen on PROD (merged by @gustavo-olmedo 7 minutes and 14 seconds ago) Please check your changes! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Updates the Puzzles and Games header with the new illustrated artwork.
Selects suitable header artwork for each responsive breakpoint and keeps
header-tablet-768pxconsistent throughout the740–979pxrange.Sets the header height to
230pxand uses the Opinion background colour,#fef9f5.Improves header positioning and image quality at desktop,
leftColandwidebreakpoints.Updates puzzle cards with their corresponding illustrations, colours and responsive dimensions.
Adds crossword setter names to crossword cards when available.
Adds alternative text to the header image and hides decorative card images from screen readers.
Updates the daily featured cards to use their corresponding puzzle artwork.
Adds the required horizontal and vertical separators between puzzle cards at each breakpoint.
Aligns category content with the Guardian grid across tablet, desktop,
leftColandwide.Updates the crossword archive dropdown with:
Adds Crossword Blog and Support the Guardian links beneath the crossword section at
leftColandwide.Updates Useful links to show Support the Guardian and Help Centre.
Keeps the newsletter and Most popular puzzles implementations available but hidden for now.
Aligns the Useful links divider with the puzzle-card divider at the
widebreakpoint.Why?
These changes bring the existing Puzzles and Games hub closer to the supplied designs across all supported breakpoints.
They address inconsistent card dimensions, low-resolution or misaligned header artwork, missing separators, archive-menu behaviour and grid alignment. They also improve accessibility by providing appropriate image semantics and keyboard behaviour.
How has this change been tested?
Added and updated Jest tests covering:
Ran the Dotcom Rendering test suite locally while developing the changes.
Manually checked the layout at mobile, phablet, tablet, desktop,
leftColandwidewidths.Compared card dimensions, separators, header positioning and container alignment against the supplied reference screenshots.
Manually verified the archive menu with pointer and keyboard interactions.