Skip to content

Include top above nav ad slot mobile on puzzles pages - #16737

Open
DanielCliftonGuardian wants to merge 3 commits into
mainfrom
top-above-nav-puzzles
Open

DanielCliftonGuardian wants to merge 3 commits into
mainfrom
top-above-nav-puzzles

Conversation

@DanielCliftonGuardian

@DanielCliftonGuardian DanielCliftonGuardian commented Sep 16, 2026

Copy link
Copy Markdown
Contributor

What does this change?

Include top above nav ad slot mobile on puzzles pages and fix ad background on wide screens

@DanielCliftonGuardian DanielCliftonGuardian self-assigned this Sep 16, 2026
@DanielCliftonGuardian DanielCliftonGuardian added run_chromatic Runs chromatic when label is applied maintenance Departmental tracking: maintenance work, not a fix or a feature labels Sep 16, 2026
@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

@DanielCliftonGuardian
DanielCliftonGuardian marked this pull request as ready for review September 16, 2026 13:08
@github-actions

Copy link
Copy Markdown

Hello 👋! When you're ready to run Chromatic, please apply the run_chromatic label to this PR.

You will need to reapply the label each time you want to run Chromatic.

Click here to see the Chromatic project.

@DanielCliftonGuardian DanielCliftonGuardian added the run_chromatic Runs chromatic when label is applied label Sep 16, 2026
@github-actions

github-actions Bot commented Sep 16, 2026

Copy link
Copy Markdown

🚀 Image pushed to AWS ECR

Image digest: sha256:2f2c6c25d0a2468d28f753e8f510c2873ab06031def201f8ce6b8679e1b6a9a8

🐛 Run the image locally

The following can be used to run the image locally:

# Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:2f2c6c25d0a2468d28f753e8f510c2873ab06031def201f8ce6b8679e1b6a9a8"

# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-top-above-nav-puzzles"

# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31233"

# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"

IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"

# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY

# Pull the image
docker pull $IMAGE

# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE

From guardian/actions-publish-image.

@github-actions github-actions Bot removed the run_chromatic Runs chromatic when label is applied label Sep 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

maintenance Departmental tracking: maintenance work, not a fix or a feature

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants