Skip to content

Include top above nav ad slot mobile on puzzles pages #16737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DanielCliftonGuardian merged 3 commits into from
Sep 17, 2026
+4 −5
Merged

Include top above nav ad slot mobile on puzzles pages #16737

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f947978
Include top above nav ad slot mobile on puzzles pages
DanielCliftonGuardian Sep 16, 2026
2217077
Fix ad background on wide screens
DanielCliftonGuardian Sep 16, 2026
f076cd2
Merge branch 'main' into top-above-nav-puzzles
DanielCliftonGuardian Sep 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions dotcom-rendering/src/components/PuzzlesDirectory.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -395,8 +395,7 @@ const nestedStyles = (span: number) => css`
`;

const adStyles = css`
max-width: 1300px;
margin: 0 auto;
width: 100%;
overflow: hidden;
background: ${palette.neutral[97]};
`;
Expand Down
4 changes: 2 additions & 2 deletions dotcom-rendering/src/layouts/PuzzlesLayout.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ describe('PuzzlesLayout', () => {
).not.toBeInTheDocument();
});

it('keeps global chrome while respecting ad-free input', () => {
it('renders both header slots without experiment participation and respects ad-free input', () => {
const { rerender } = render(
<PuzzlesLayout NAV={nav} puzzlesPage={page(true) as never} />,
);
Expand All @@ -62,7 +62,7 @@ describe('PuzzlesLayout', () => {
).toBeInTheDocument();
expect(
document.getElementById('dfp-ad--mobile-above-nav'),
).not.toBeInTheDocument();
).toBeInTheDocument();
});
it('renders the illustrated header with responsive sources and a fixed height', () => {
render(<PuzzlesLayout NAV={nav} puzzlesPage={page() as never} />);
Expand Down
2 changes: 1 addition & 1 deletion dotcom-rendering/src/layouts/PuzzlesLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ export const PuzzlesLayout = ({
padSides={false}
shouldCenter={false}
>
<HeaderAdSlot />
<HeaderAdSlot includeMobile={true} />
</Section>
</Stuck>
)}
Expand Down
Loading