Conversation
🚀 Image pushed to AWS ECRImage digest: 🐛 Run the image locallyThe following can be used to run the image locally: # Refer to image using the immutable digest. Find alternatives below.
IMAGE_IDENTIFIER="@sha256:814333c9b897a454658d6ae7cb7156d1ac131c72e8f6b55374cbff0b8543897f"
# Refer to image using branch tag
# IMAGE_IDENTIFIER=":branch-dina-open-up-article-end-for-prebid"
# Refer to image using build tag
# IMAGE_IDENTIFIER=":build-31258"
# Set environment variables for the AWS CLI
AWS_PROFILE="<A_PROFILE_FROM_JANUS>"
AWS_DEFAULT_REGION="eu-west-1"
IMAGE_ACCOUNT_ID=$(aws ssm get-parameter --name /organisation/accounts/artifacts --query "Parameter.Value" --output text)
REGISTRY="${IMAGE_ACCOUNT_ID}.dkr.ecr.${AWS_DEFAULT_REGION}.amazonaws.com"
IMAGE="${REGISTRY}/guardian/dotcom-rendering${IMAGE_IDENTIFIER}"
# Login to AWS ECR https://docs.aws.amazon.com/AmazonECR/latest/userguide/registry_auth.html
aws ecr get-login-password | docker login --username AWS --password-stdin $REGISTRY
# Pull the image
docker pull $IMAGE
# Run the image. You'll likely need to set additional flags. See https://docs.docker.com/reference/cli/docker/container/run.
docker run $IMAGE |
deedeeh
force-pushed
the
dina/open-up-article-end-for-prebid
branch
from
September 16, 2026 14:08
945a074 to
6f8eabc
Compare
deedeeh
force-pushed
the
dina/open-up-article-end-for-prebid
branch
from
September 16, 2026 16:26
d3f81e3 to
992962d
Compare
deedeeh
marked this pull request as ready for review
September 16, 2026 16:26
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Open up the
article-endad slot for Header Bidding instead of the exclusivity of Public Good. This slot exists in US region and the user should be in the variant, now we have a 0% test.Why?
We want to test if this slot will have a revenue from programmatic as Public Good will be moved to Direct Sponsorship which will be setup by AdOps.
How has this change been tested?
Tested locally and in CODE.
Make sure you are in US with a VPN and check the changes in https://theguardian.com/ab-tests/opt-in/commercial-article-end-header-bidding:variant
The Prebid request won't happen if we are serving an epic but if we meet all conditions and no epic to be served then a request will be made even if no bids were successful and the slot collapses.
Related PR: guardian/commercial#2736
Screenshots