Format football scorer other info added time minutes to xth minute - #16756
Open
andrewHEguardian wants to merge 1 commit into
Open
andrewHEguardian wants to merge 1 commit into
andrewHEguardian wants to merge 1 commit into
Conversation
andrewHEguardian
added
the
maintenance
|
Hello 👋! When you're ready to run Chromatic, please apply the You will need to reapply the label each time you want to run Chromatic. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Changes the way football scorer times in added time (not extra time) are formatted from "+mm:ss" to "+m". In the new format m is the ordinal minute, i.e. if a goal is scored at +0:32 it is the first minute, so +1
Why?
As pointed out on Reddit, this is unusual. Although the most upvoted comment is that it's good, so maybe it's fine! 🤷 The original comes straight from PA.
This is how other outlets like BBC report these goals
Or our own live blog
How has this change been tested?
Tested locally + unit test
Screenshots
The fact his name comes through as "Junior Neymar" could be tackled another day...