Problem
As noted in #2000.
If the config for collections is unavailable the Fronts tool is unable to determine which permissions are required to interact with it. Currently the tool assumes no permissions are required. In practice this should be unlikely but is a potentially dangerous assumption to make.
|
logger.warn( |
|
"No config found when checking required permissions for a collection" |
|
) |
|
Set.empty[ |
|
PermissionsPriority |
|
] // if there are no fronts in config, there can be no permissions....? |
We can check the warning logs to see how frequently this case occurs.
Solution
Determine as sensible approach for handling a lack of config when determining required permissions for a collection:
- Should we assume all permissions are required?
- Should we simply reject the request with a 5XX error?
Problem
As noted in #2000.
If the config for collections is unavailable the Fronts tool is unable to determine which permissions are required to interact with it. Currently the tool assumes no permissions are required. In practice this should be unlikely but is a potentially dangerous assumption to make.
facia-tool/app/permissions/CollectionPermissions.scala
Lines 12 to 17 in 93fd82d
We can check the warning logs to see how frequently this case occurs.
Solution
Determine as sensible approach for handling a lack of config when determining required permissions for a collection: