Conversation
7a665f4 to
2b6c1b5
Compare
simonbyford
left a comment
There was a problem hiding this comment.
Looks good to me! Tested on CODE and everything works as expected
Fweddi
left a comment
There was a problem hiding this comment.
We might also need to adjust for the US network front in:
-
facia-tool/fronts-client/src/components/FrontsEdit/CollectionOverview.tsx
Lines 246 to 249 in 1852a7a
We could include a test for fronts restriction if we wanted to (mirroring DCR).
I've checked the original ticket and actually we were planning to remove the feature switch in this PR, which makes sense as we want everyone to be able to see the tests on the US front regardless of whether they have their feature switch enabled. Might be worth changing this PR to reflect that? |
13a7ca2 to
84965da
Compare
Thanks @Fweddi. As suggested, I've replaced all the switch checks for US front checks 👍 |
84965da to
cdf4eed
Compare
What's changed?
Adds a guard to headline ab testing functionality so that it is only available on the US front. This is for the initial rollout only so that we can limit behaviour to a smaller subset of users.
Removal of this restriction will be covered by guardian/frontend#29129, once initial testing has finished.
This should not be merged until we are ready to rollout to production users.
Implementation notes
Checklist
General
Client