Skip to content

Only allow headline ab testing on the US network front - #2059

Open
abeddow91 wants to merge 3 commits into
mainfrom
ab/add-us-front-restriction
Open

abeddow91 wants to merge 3 commits into
mainfrom
ab/add-us-front-restriction

Conversation

@abeddow91

Copy link
Copy Markdown
Contributor

What's changed?

Adds a guard to headline ab testing functionality so that it is only available on the US front. This is for the initial rollout only so that we can limit behaviour to a smaller subset of users.

Removal of this restriction will be covered by guardian/frontend#29129, once initial testing has finished.

This should not be merged until we are ready to rollout to production users.

Implementation notes

Checklist

General

  • 🤖 Relevant tests added
  • ✅ CI checks / tests run locally
  • 🔍 Checked on CODE

Client

  • 🚫 No obvious console errors on the client (i.e. React dev mode errors)
  • 🎛️ No regressions with existing user interactions (i.e. all existing buttons, inputs etc. work)
  • 📷 Screenshots / GIFs of relevant UI changes included

@github-actions

github-actions Bot commented Aug 26, 2026

Copy link
Copy Markdown

@simonbyford simonbyford left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Tested on CODE and everything works as expected

@Fweddi Fweddi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might also need to adjust for the US network front in:

We could include a test for fronts restriction if we wanted to (mirroring DCR).

@Fweddi

Fweddi commented Aug 27, 2026

Copy link
Copy Markdown
Contributor

We might also need to adjust for the US network front in:

We could include a test for fronts restriction if we wanted to (mirroring DCR).

I've checked the original ticket and actually we were planning to remove the feature switch in this PR, which makes sense as we want everyone to be able to see the tests on the US front regardless of whether they have their feature switch enabled. Might be worth changing this PR to reflect that?

@abeddow91
abeddow91 force-pushed the ab/add-us-front-restriction branch from 13a7ca2 to 84965da Compare September 1, 2026 14:40
@abeddow91

Copy link
Copy Markdown
Contributor Author

I've checked the original ticket and actually we were planning to remove the feature switch in this PR, which makes sense as we want everyone to be able to see the tests on the US front regardless of whether they have their feature switch enabled. Might be worth changing this PR to reflect that?

Thanks @Fweddi. As suggested, I've replaced all the switch checks for US front checks 👍

@abeddow91
abeddow91 requested a review from Fweddi September 2, 2026 08:52
@abeddow91 abeddow91 added the feature Departmental tracking: work on a new feature label Sep 2, 2026
@abeddow91
abeddow91 marked this pull request as draft September 2, 2026 08:53
@abeddow91
abeddow91 force-pushed the ab/add-us-front-restriction branch from 84965da to cdf4eed Compare September 2, 2026 08:55
@abeddow91
abeddow91 marked this pull request as ready for review September 2, 2026 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge feature Departmental tracking: work on a new feature

Projects

None yet

3 participants