Set up takedown page UI - #4934
Conversation
1529e91 to
be284a2
Compare
be284a2 to
8a6fc7c
Compare
4965e91 to
5ff60d8
Compare
2d72bd9 to
0df1dff
Compare
| </Layout.Main> | ||
| </Layout> | ||
| </div> | ||
| ); |
There was a problem hiding this comment.
I like this flow.
I'm wondering a bit about the status updates.
We can get to it nearer the time, but I think it would be good to use the data from the API to say whether or not it can be clicked
There was a problem hiding this comment.
Yes, this will be based on data-fetching results inside a context provider: https://github.com/guardian/grid/pull/4935/changes#diff-32c0a79d82d1fd5f0c4e9c8e458d55c64537f51cc7144f77acbaaa3b6daeccb9
0df1dff to
16a4f2b
Compare
16a4f2b to
7651b08
Compare
|
Seen on auth, metadata-editor, cropper, media-api, kahuna (merged by @junyuanxue 10 minutes and 40 seconds ago) Please check your changes! |
|
Seen on collections, leases, usage (merged by @junyuanxue 10 minutes and 51 seconds ago) Please check your changes! |
|
Seen on image-loader, thrall (merged by @junyuanxue 11 minutes ago) Please check your changes! |
What does this change?
A scaffold of takedown page UI, with some placeholder copy for each step.
@guardian/standcomponents. I've added some default theme overrides to support the dark background of the Grid.@emotion/react, in line with@guardian/standstyle overrides, so we don't have the problem of having multiple ways of styling within one component. (And generally, I think we should move away from CSS stylesheets and towards more localised styles and leaning on thematic abstraction rather than abstraction by custom classnames).kahuna.conffor now.How should a reviewer test this change?
~/.grid/kahuna.conf, addimage.takedown.enabled=true, run the Grid using--use-TESTso you have permissionsTested? Documented?