Skip to content

Set up takedown page UI - #4934

Merged
junyuanxue merged 1 commit into
mainfrom
09-11-takedown_page_ui
Sep 16, 2026
Merged

junyuanxue merged 1 commit into
mainfrom
09-11-takedown_page_ui

Conversation

@junyuanxue

@junyuanxue junyuanxue commented Sep 14, 2026

Copy link
Copy Markdown
Contributor

What does this change?

A scaffold of takedown page UI, with some placeholder copy for each step.

  • Page /takedown is set up with React, and uses @guardian/stand components. I've added some default theme overrides to support the dark background of the Grid.
  • I've opted for custom styling localised to elements using @emotion/react, in line with @guardian/stand style overrides, so we don't have the problem of having multiple ways of styling within one component. (And generally, I think we should move away from CSS stylesheets and towards more localised styles and leaning on thematic abstraction rather than abstraction by custom classnames).
  • Some base sketch and UI of hard-coded takedown steps - these will be filled out in upstack PRs.
  • Page is behind a feature switch through kahuna.conf for now.

How should a reviewer test this change?

  • In your local ~/.grid/kahuna.conf, add image.takedown.enabled=true, run the Grid using --use-TEST so you have permissions
  • Go to an image page, and append '/takedown' at the end of the url. You'll need the 'delete_crops_or_usages' permission to access it
Screenshot 2026-09-14 at 14 57 45

Tested? Documented?

  • locally by committer
  • locally by Guardian reviewer
  • on the Guardian's TEST environment
  • relevant documentation added or amended (if needed)

@junyuanxue
junyuanxue force-pushed the 09-11-takedown_page_ui branch from 1529e91 to be284a2 Compare September 14, 2026 12:08
@junyuanxue
junyuanxue added this pull request to stack #4936 September 14, 2026 12:09
@junyuanxue
junyuanxue force-pushed the 09-11-takedown_page_ui branch from be284a2 to 8a6fc7c Compare September 14, 2026 12:10
@junyuanxue junyuanxue closed this Sep 14, 2026
@github-actions

github-actions Bot commented Sep 14, 2026

Copy link
Copy Markdown

@junyuanxue junyuanxue reopened this Sep 14, 2026
@junyuanxue junyuanxue added the feature Departmental tracking: work on a new feature label Sep 14, 2026
@junyuanxue junyuanxue changed the title Takedown page UI Set up takedown page UI Sep 14, 2026
@junyuanxue
junyuanxue force-pushed the 09-11-takedown_page_ui branch 3 times, most recently from 4965e91 to 5ff60d8 Compare September 14, 2026 14:57
@junyuanxue
junyuanxue marked this pull request as ready for review September 14, 2026 15:42
@junyuanxue
junyuanxue requested a review from a team as a code owner September 14, 2026 15:42
@junyuanxue
junyuanxue force-pushed the 09-11-takedown_page_ui branch 2 times, most recently from 2d72bd9 to 0df1dff Compare September 15, 2026 14:02

@lindseydew lindseydew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice work ✨

</Layout.Main>
</Layout>
</div>
);

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this flow.

I'm wondering a bit about the status updates.

We can get to it nearer the time, but I think it would be good to use the data from the API to say whether or not it can be clicked

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@junyuanxue
junyuanxue force-pushed the 09-11-takedown_page_ui branch from 0df1dff to 16a4f2b Compare September 16, 2026 12:52
@gu-prout

gu-prout Bot commented Sep 16, 2026

Copy link
Copy Markdown

Seen on auth, metadata-editor, cropper, media-api, kahuna (merged by @junyuanxue 10 minutes and 40 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented Sep 16, 2026

Copy link
Copy Markdown

Seen on collections, leases, usage (merged by @junyuanxue 10 minutes and 51 seconds ago) Please check your changes!

@gu-prout

gu-prout Bot commented Sep 16, 2026

Copy link
Copy Markdown

Seen on image-loader, thrall (merged by @junyuanxue 11 minutes ago) Please check your changes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants