Conversation
…ntent, modify preview with `showPreview` parameter
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this change?
Changes the component that loads and renders the preview of the Newsletter content to:
How has this change been tested?
Ran locally, added stories for the updated component.
How can we measure success?
Better user experience for email previews
Have we considered potential risks?
We don't have specific designs for this component, or its loading/error/placeholder state - should get this version looked over
In theory, it is more secure to renderer arbitrary HTML string in an iframe, but in practise, we are fetching content from our own rendering service, so can expect it to be safe.
Images
Accessibility