Conversation
Contributor
Contributor
|
Size Change: +39 B (0%) Total Size: 1.87 MB ℹ️ View Unchanged
|
Contributor
Member
|
Adding "Do not merge" label as this would be part of the Multiple Accounts project phase 2 (enabling the feature for new acquisitions) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What are you doing in this PR?
Enabling the thank-you onboarding experience for Digital+. Until now only Supporter Plus reached the onboarding flow after checkout — Digital+ purchasers dropped through to the legacy thank-you cards.
Why are you doing this?
Digital+ should get the same post-purchase onboarding as Supporter Plus. The gate that decides whether to show onboarding compared the support-workers product name (
DigitalPack) against a list of frontend catalog keys, so Digital+ never matched. This PR translates the workers product name to its catalog key (DigitalSubscription) server-side before the comparison, and adds the key to the onboarding list so the product is recognised.How to test
On this branch, buy a Digital+ subscription on
/ukand land on the thank-you page: the onboarding experience now shows instead of the legacy cards. The product-key translation is covered by a new unit test (CreateSubscriptionControllerTest). Note the onboarding content comes from the landing-page settings (RRCP/DynamoDB); locally it can be previewed withforce-landing-page=AB_DIGITAL_PLUS_TEST:DP_TEST.Have we considered potential risks?
Low risk. The behaviour stays gated behind the existing
enableThankYouOnboardingswitch. The only change is that Digital+ now matches the onboarding list — other products are unaffected, as the translation falls back to the simple class name for everything else.