Merge pull request #618 from guardian/ld/intended-audience-cleanup

Some cleanup for the intended audience feature

Author: liamness

app/controllers/Api.scala

@@ -208,17 +208,6 @@ class Api(
     }
   }
 
-  def putStubIntendedAudience(stubId: Long) = {
-    APIAuthAction.async { request =>
-      ApiResponseFt[Long](for {
-        json <- readJsonFromRequestResponse(request.body)
-        intendedAudience <- extractDataResponse[Option[String]](json)
-        id <- stubsApi.updateIntendedAudience(stubId, intendedAudience)
-      } yield id
-      )
-    }
-  }
-
   def putStubStatusByComposerId(composerId: String) = {
     APIAuthAction.async { request =>
       ApiResponseFt[String](for {

common-lib/src/main/scala/com/gu/workflow/api/StubAPI.scala

@@ -214,13 +214,6 @@ class StubAPI(
       item <- extractDataResponse[Long](json)
     } yield item
 
-  def updateIntendedAudience(stubId: Long, updateIntendedAudience: Option[String]): ApiResponseFt[Long] =
-    for {
-      res <- ApiResponseFt.Async.Right(putRequest(s"stubs/$stubId/intendedAudience", updateIntendedAudience.asJson))
-      json <- parseBody(res.body)
-      item <- extractDataResponse[Long](json)
-    } yield item
-
   def updateContentStatusByComposerId(composerId: String, status: String): ApiResponseFt[String] =
     for {
       res <- ApiResponseFt.Async.Right(putRequest(s"content/$composerId/status", status.asJson))

common-lib/src/main/scala/models/Stub.scala

@@ -54,8 +54,7 @@ case class ExternalData(
                          rightsDeveloperCommunity: Option[Boolean] = None,
                          byline: Option[String] = None,
                          displayHint: Option[String] = None,
-                         trackingTags: Option[List[String]] = None,
-                         intendedAudience: Option[String] = None) {
+                         trackingTags: Option[List[String]] = None) {
 }
 
 object ExternalData {

conf/routes

@@ -52,7 +52,6 @@ PUT            /api/stubs/:stubId/plannedNewspaperPublicationDate     controller
 PUT            /api/stubs/:stubId/rightsReviewed           controllers.Api.putStubRightsReviewed(stubId: Long)
 PUT            /api/stubs/:stubId/commissionedLength       controllers.Api.putStubCommissionedLength(stubId: Long)
 PUT            /api/stubs/:stubId/missingCommissionedLengthReason     controllers.Api.putStubMissingCommissionedLengthReason(stubId: Long)
-PUT            /api/stubs/:stubId/intendedAudience         controllers.Api.putStubIntendedAudience(stubId: Long)
 DELETE         /api/stubs/:stubId                          controllers.Api.deleteStub(stubId: Long)
 
 GET            /api/statuses                               controllers.Api.statusus

public/lib/model/stub.ts

@@ -30,7 +30,6 @@ export type Stub = {
   prodOffice?: string;
   note?: string;
   displayHint?: string;
-  intendedAudience?: string;
 };
 
 export type ListElementArticleFormat = {