Merge pull request #595 from guardian/dblatcher/intended-audience-on-by-default

intended audience on by default

Author: dblatcher

public/components/feature-switches/feature-switches.js

@@ -7,7 +7,7 @@
 import angular from 'angular';
 import featureSwitches from './feature-switches.html';
 import _ from 'lodash';
-import { featureSwitchKeys, getDefaultFeatureSwitchValues } from "../../lib/feature-switches.ts"
+import { featureSwitchKeys, getDefaultFeatureSwitchValues, featureSwitchReadableNames } from "../../lib/feature-switches.ts"
 
 angular.module('wfFeatureSwitches', ['wfPreferencesService', 'wfIcons'])
     .directive('wfFeatureSwitches', [wfFeatureSwitchesDirective]);
@@ -41,10 +41,7 @@ class FeatureSwitches {
 
 function wfFeatureSwitchesController ($scope, wfPreferencesService) {
 
-    $scope.readableNames = {
-        // e.g. 'multiByline': 'Multi-byline',
-        'intendedAudienceColumn': 'Show Intended Audience'
-    }
+    $scope.readableNames = featureSwitchReadableNames
 
     // Feature switches are provided to the directive as an array of entries because it's simpler to iterate through in ng-repeat
     $scope.featureSwitchEntries = Object.entries(getDefaultFeatureSwitchValues()).filter(featureSwitch => featureSwitchKeys.includes(featureSwitch[0]))

public/lib/feature-switches.ts

@@ -1,13 +1,33 @@
-
 type FeatureSwitchData = Record<string, unknown>;
 
-export const featureSwitchKeys = [
-  // e.g. 'multiByline'
-  "intendedAudienceColumn",
+type FeatureSwitch = {
+  key: string;
+  defaultValue: boolean;
+  description: string;
+};
+
+const featureSwitchList: FeatureSwitch[] = [
+  {
+    key: "intendedAudienceColumn",
+    defaultValue: true,
+    description: "Show Intended Audience",
+  },
 ];
 
-export const getDefaultFeatureSwitchValues = ():FeatureSwitchData => {
-  const switches:FeatureSwitchData = {};
-  featureSwitchKeys.forEach((key) => (switches[key] = false));
+export const featureSwitchKeys = featureSwitchList.map(
+  (featureSwitch) => featureSwitch.key,
+);
+
+export const getDefaultFeatureSwitchValues = (): FeatureSwitchData => {
+  const switches: FeatureSwitchData = {};
+  featureSwitchList.forEach(
+    ({ key, defaultValue }) => (switches[key] = defaultValue),
+  );
   return switches;
 };
+
+export const featureSwitchReadableNames = featureSwitchList.reduce<
+  Record<string, string>
+>((namesMap, nextSwitch) => {
+  return { ...namesMap, [nextSwitch.key]: nextSwitch.description };
+}, {});