Allow iv as a selection_criteria metric for continuous targets - #396
Open
lcrmorin wants to merge 1 commit into
Open
Allow iv as a selection_criteria metric for continuous targets#396lcrmorin wants to merge 1 commit into
lcrmorin wants to merge 1 commit into
Conversation
lcrmorin
force-pushed
the
fix-selection-criteria-iv-continuous
branch
from
August 23, 2026 18:59
184d00c to
244ac7d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #307. ContinuousBinningTable already computes and exposes IV via .iv, identically to the binary case, but it was never added to BinningProcess's _METRICS config, so selection_criteria={"iv": ...} raised ValueError for continuous targets and summary() never showed an iv column even though the value was directly accessible via get_binned_variable(name).binning_table.iv. Added iv to the continuous metrics list and to the per-variable stats dict in _binning_selection_criteria(), mirroring the binary branch. Added a regression test verifying summary() now includes iv (matching the binning table's own value) and that selection_criteria on iv filters correctly for continuous targets. Verified the test fails against the pre-fix code.