fix(accordion): correct typo in disabled Title color theme key - #966
Open
zigzagdev wants to merge 1 commit into
Open
fix(accordion): correct typo in disabled Title color theme key#966zigzagdev wants to merge 1 commit into
zigzagdev wants to merge 1 commit into
Conversation
Title referenced theme.colors.text.secundary, which does not exist, instead of text.secondary. Fix the typo so the intended theme value resolves correctly if this style path is ever reached.
zigzagdev
requested review from
a team,
flaviafmoraes,
matheus-wh and
wellhub-gsevla
as code owners
September 5, 2026 07:28
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Title referenced theme.colors.text.secundary, which does not exist, instead of text.secondary. Fix the typo so the intended theme value resolves correctly if this style path is ever reached.
Description 📄
[Enter the description of your changes]
Title (in Accordion/web/Accordion.jsx) referenced theme.colors.text.secundary, which does not exist, instead of text.secondary.
This resolved to undefined and produced an invalid color: undefined; declaration.
Fixed the typo so the intended theme value resolves correctly.
Note
This style block is currently only applied when disabled is true on Title, and Title does not presently receive a disabled prop from Accordion.
So, this code path is not reached today (the visible disabled text color is handled separately via the Text component's colour prop).
This PR only fixes the typo so the theme reference is correct if/when this path is used, whether the block is dead code worth removing is being tracked separately.
Platforms 📲
Type of change 🔍
How Has This Been Tested? 🧪
[Enter the tips to test this PR]
Ran the full Accordion test suite locally.
Checklist: 🔍
Screenshots 📸
N/A
[Upload your screenshots here]