Skip to content

fix(accordion): correct typo in disabled Title color theme key - #966

Open
zigzagdev wants to merge 1 commit into
gympass:masterfrom
zigzagdev:fix/accordion-secondary-color-typo
Open

fix(accordion): correct typo in disabled Title color theme key#966
zigzagdev wants to merge 1 commit into
gympass:masterfrom
zigzagdev:fix/accordion-secondary-color-typo

Conversation

@zigzagdev

@zigzagdev zigzagdev commented Sep 5, 2026

Copy link
Copy Markdown

Title referenced theme.colors.text.secundary, which does not exist, instead of text.secondary. Fix the typo so the intended theme value resolves correctly if this style path is ever reached.

JIRA Issue

Description 📄

[Enter the description of your changes]

Title (in Accordion/web/Accordion.jsx) referenced theme.colors.text.secundary, which does not exist, instead of text.secondary.
This resolved to undefined and produced an invalid color: undefined; declaration.
Fixed the typo so the intended theme value resolves correctly.

Note

This style block is currently only applied when disabled is true on Title, and Title does not presently receive a disabled prop from Accordion.
So, this code path is not reached today (the visible disabled text color is handled separately via the Text component's colour prop).
This PR only fixes the typo so the theme reference is correct if/when this path is used, whether the block is dead code worth removing is being tracked separately.

Platforms 📲

  • Web
  • Mobile

Type of change 🔍

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested? 🧪

[Enter the tips to test this PR]

Ran the full Accordion test suite locally.

  • Unit Test
  • Snapshot Test

Checklist: 🔍

  • My code follows the contribution guide of this project Contributing Guide
  • Layout matches design prototype: FIGMA
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • I have checked my code and corrected any misspellings

Screenshots 📸

N/A

[Upload your screenshots here]

Before After

Title referenced theme.colors.text.secundary, which does not exist,
instead of text.secondary. Fix the typo so the intended theme value
resolves correctly if this style path is ever reached.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant