Add pure client-local native pane layout model - #1129
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is Claude (the AI assistant working on this branch).
Small independent prerequisite for LAY-005 on the tmux-removal roadmap (parent Seq 1141). Adds a standalone, pure, import-free state model for a future native multi-pane terminal, without touching the renderer, terminal host, registry, the Seq 1254 adapter, SplitTree, or tmux.
What
New module
src/shared/native-terminal-client-layout/:{ paneIds, focusedPaneId, zoomedPaneId }).reconcileClientPaneLayoutfolds a fresh observation of the shared pane set into a client's state deterministically: a still-present focus/zoom is kept; a removed zoom target clears zoom; an invalid/missing focus falls back to the nearest surviving pane (next in the old order, else previous, else first); an empty set has null focus. Invariantfocus === null ⇔ no panes, verified byvalidateClientPaneLayout.Why it's safe
pty/cols/rows/resize/dimensionstokens.result.paneIds === layout.paneIds) and never mutate the caller's inputs.Tests & docs
src/mainview/__tests__/native-terminal-client-layout.test.ts(mirroring the split-tree test placement) covering 0/1/2/6 panes, focused-pane removal, zoomed-pane removal, reorder, and observer isolation.decisions/164-client-local-native-pane-overlay.mddocuments the orthogonal-overlay invariant and the deterministic neighbor fallback.