Move testing detail into a verify-changes skill and tip rubric into TipScore - #1140
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applies progressive disclosure to the agent instructions: bulky reference material moves to where it is loaded on demand, while the load-bearing rules stay inline in
AGENTS.md..claude/skills/verify-changes/SKILL.md— which vitest config covers what, what a change needs covered, house style (incl. the query patterns that flake under CI load), mocking Electrobun RPC anduseT(), reproduce-under-load workflow for flakes, and coverage expectations.AGENTS.mdTesting section reduced to the framework line, the commands block, a pointer to the skill, and the two hard gates. The gates and the mandatory browser QA / streamer-mode rules deliberately stay inline — an agent that never loads the skill must still hit them.TipScoretype insrc/mainview/tips.tsas a discriminated1 | 2 | 3 | 4 | 5union with the rubric in its doc comment;AGENTS.mdnow points at the type instead of restating 20 lines of prose. Side effect: an out-of-rangescoreis now a type error.Key fileslist extended from 4 to 13 verified entries (shared types, RPC handler barrel, reducer, design tokens, keymap, shipped skill text, CLI exit codes, CI workflows, decision records) — the list exists so an agent knows these files are there, not as a summary of them.Net:
AGENTS.md429 → 388 lines.