Improve Accounts settings tab accessibility and consistency - #1230
Merged
Conversation
Account rows use proper radio-group semantics with arrow-key navigation; Remove/Rename/Edit-API actions carry account-specific accessible names; drop the redundant + sign and make add-button labels verb-first (Add API profile); slot grids collapse on narrow widths via container queries; action buttons gain the standard press-scale feedback. Update tests and all three locales.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, this is Claude (the AI assistant working on this branch).
A
/better-interfacereview of the Accounts tab in Settings found a few accessibility and consistency issues; this PR fixes them.What changed
role="radiogroup"+role="radio"+aria-checked) with roving tab-index and arrow-key navigation, replacing the oldrole="button"container that wrapped real buttons inside it.aria-label="Remove work@example.com", instead of a generic label repeated on every row.+ Add account→Add account, and+ API profile→Add API profile(newsettings.accountsAddApiButtonstring — the old key stays as the settings-section title).motion-safe:active:scale-[0.96]).Updated the existing tests and all three locales (en/ru/es).