[actions] run GHA quick checks in stacks, selectively - #15657
Open
cjllanwarne wants to merge 4 commits into
Open
cjllanwarne wants to merge 4 commits into
cjllanwarne wants to merge 4 commits into
Conversation
cjllanwarne
changed the title
cjllanwarne
changed the title
cjllanwarne
requested review from
kush-chandra and
patrick-schultz
and
a lite review from Copilot
September 3, 2026 18:08
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The new gating logic can unexpectedly skip checks due to a non-existent mergeable label and can also mask failures if the should-run job fails (workflow may go green incorrectly).
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR updates the “Static Analysis and Unit Tests” GitHub Actions workflow to selectively run the “quick checks” for PRs that are part of GitHub stacks, skipping intermediate stack PRs, and to adjust the target SHA used by service checks for stacked PRs.
Changes:
- Add a
should-runjob that decides whether the rest of the quick-check jobs should execute. - Gate most jobs behind
needs: should-run+if: needs.should-run.outputs.run == 'true'. - For
check-services, use the stack’s ultimate base SHA (when present) to improve diffing behavior.
File summaries
| File | Description |
|---|---|
| .github/workflows/static-and-unit-tests.yml | Adds should-run gating logic, updates check-services target SHA selection for stacks, and updates gate behavior. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 2
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
cjllanwarne
added
the
mergeable
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Only impacts PRs which are part of github stacks. Automatically skips the actions if the PR is not the head.
Note: these checks are not official gating checks. They are quick version of actions which also happen in the full CI run, to give faster feedback. So skipping them on intermediate commits is fine.
Security Assessment