[ci] fix how tactical retries work when build.yaml is changed - #15705
Open
cjllanwarne wants to merge 1 commit into
Open
cjllanwarne wants to merge 1 commit into
cjllanwarne wants to merge 1 commit into
Conversation
grohli
approved these changes
Aug 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change Description
Updates tactical retries to work properly with build.yaml changes.
Previously we had a gating check such that if all tests were being requested, the tactical retest request was being ignored. That's not quite the right semantics. We want all tests to be attempted, but if one has already passed there's no reason to re-run it, especially if the retry was requested tactically.
Therefore, for all tactical builds:
requested_stepssetrequested_stepsSecurity Assessment
Impact Rating
Impact Description
Small tweak to fix test step selection
Appsec Review