improved diff summaries - #11
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the core PoamFileDiff.print_summary() output to make diff results easier to scan in the CLI by emphasizing newly opened (and intended: reopened) items, while keeping non-actionable categories compact.
Changes:
- Replaced verbose per-category sections with a top-level summary of key counts.
- Added scannable bulleted lists for newly opened POAMs and newly opened configuration findings (including risk rating and detection date).
- Added a compact “reopened” section (currently less detailed than the “opened” sections).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+171
to
+174
| print("\n=== Reopened Findings ({}) ===".format(len(self.reopened_findings))) | ||
| if self.reopened_findings: | ||
| for match in self.reopened_findings[:max_preview]: | ||
| print(f"- [{match.poam.poam_id}] {match.poam.weakness_name} — {match.finding.finding_id}") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Show actual content for opened and reopened poams. Just summaries for everything else.