address code review comments

Author: kibertoad

spec/env/common.js

@@ -175,14 +175,23 @@ HandlebarsTestBench.prototype.toCompileTo = function (expectedOutputAsString) {
 
 HandlebarsTestBench.prototype.toThrow = function (errorLike, errMsgMatcher) {
   var self = this;
-  if (errMsgMatcher) {
-    expect(function () {
-      self._compileAndExecute();
-    }).toThrowError(errMsgMatcher);
-  } else {
-    expect(function () {
-      self._compileAndExecute();
-    }).toThrow();
+  var caught;
+  try {
+    self._compileAndExecute();
+  } catch (e) {
+    caught = e;
+  }
+
+  expect(caught).toBeDefined();
+
+  if (typeof errorLike === 'function') {
+    expect(caught).toBeInstanceOf(errorLike);
+    if (errMsgMatcher) {
+      expect(caught.message).toMatch(errMsgMatcher);
+    }
+  } else if (errorLike) {
+    // errorLike is a string or regex message matcher (single-argument form)
+    expect(caught.message).toMatch(errorLike);
   }
 };
 

spec/security.js

@@ -109,20 +109,23 @@ describe('security issues', function () {
   });
 
   describe('GH-1563', function () {
-    it('should not allow to access constructor after overriding via __defineGetter__', function () {
-      if ({}.__defineGetter__ == null || {}.__lookupGetter__ == null) {
-        return; // Browser does not support this exploit anyway
+    var browserSupportsExploit =
+      {}.__defineGetter__ != null && {}.__lookupGetter__ != null;
+
+    it.skipIf(!browserSupportsExploit)(
+      'should not allow to access constructor after overriding via __defineGetter__',
+      function () {
+        expectTemplate(
+          '{{__defineGetter__ "undefined" valueOf }}' +
+            '{{#with __lookupGetter__ }}' +
+            '{{__defineGetter__ "propertyIsEnumerable" (this.bind (this.bind 1)) }}' +
+            '{{constructor.name}}' +
+            '{{/with}}'
+        )
+          .withInput({})
+          .toThrow(/Missing helper: "__defineGetter__"/);
       }
-      expectTemplate(
-        '{{__defineGetter__ "undefined" valueOf }}' +
-          '{{#with __lookupGetter__ }}' +
-          '{{__defineGetter__ "propertyIsEnumerable" (this.bind (this.bind 1)) }}' +
-          '{{constructor.name}}' +
-          '{{/with}}'
-      )
-        .withInput({})
-        .toThrow(/Missing helper: "__defineGetter__"/);
-    });
+    );
   });
 
   describe('GH-1595: dangerous properties', function () {

vitest.config.js

@@ -18,6 +18,7 @@ export default defineConfig({
           name: 'tasks',
           include: ['tasks/tests/*.test.js'],
           globals: true,
+          pool: 'forks',
         },
       },
       {