Skip to content

fix: enable shell mode for spawn to resolve Windows EINVAL issue - #2115

Merged
jaylinski merged 1 commit into
handlebars-lang:4.xfrom
tylerablackham:fix/windows-build-error
Feb 7, 2026
Merged

fix: enable shell mode for spawn to resolve Windows EINVAL issue#2115
jaylinski merged 1 commit into
handlebars-lang:4.xfrom
tylerablackham:fix/windows-build-error

Conversation

@tylerablackham

@tylerablackham tylerablackham commented Dec 8, 2025

Copy link
Copy Markdown

Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.

Generally we like to see pull requests that

  • Please don't start pull requests for security issues. Instead, file a report at https://www.npmjs.com/advisories/report?package=handlebars
  • Maintain the existing code style
  • Are focused on a single change (i.e. avoid large refactoring or style adjustments in untouched code if not the primary goal of the pull request)
  • Have good commit messages
  • Don't significantly decrease the current code coverage (see coverage/lcov-report/index.html)
  • Currently, the 4.x-branch contains the latest version. Please target that branch in the PR.

This change addresses issue: #2111 / #2114

@jaylinski
jaylinski self-requested a review December 9, 2025 20:53
@jaylinski

Copy link
Copy Markdown
Member

Note: CI lint fail has nothing to do with this change. We have to fix this separately.

@biplavbarua biplavbarua left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified locally on macOS. The grunt parser task runs successfully. The DeprecationWarning regarding shell: true is observed but acceptable here since the arguments are hardcoded file paths, minimizing injection risk. This change should resolve the Windows spawn issues as intended. LGTM.

@jaylinski
jaylinski merged commit e0137c2 into handlebars-lang:4.x Feb 7, 2026
13 of 15 checks passed
@jaylinski

Copy link
Copy Markdown
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants