fix: enable shell mode for spawn to resolve Windows EINVAL issue - #2115
Merged
jaylinski merged 1 commit intoFeb 7, 2026
Merged
Conversation
jaylinski
self-requested a review
December 9, 2025 20:53
Member
|
Note: CI lint fail has nothing to do with this change. We have to fix this separately. |
jaylinski
approved these changes
Dec 9, 2025
biplavbarua
approved these changes
Jan 14, 2026
biplavbarua
left a comment
There was a problem hiding this comment.
Verified locally on macOS. The grunt parser task runs successfully. The DeprecationWarning regarding shell: true is observed but acceptable here since the arguments are hardcoded file paths, minimizing injection risk. This change should resolve the Windows spawn issues as intended. LGTM.
Member
|
Thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before creating a pull-request, please check https://github.com/handlebars-lang/handlebars.js/blob/master/CONTRIBUTING.md first.
Generally we like to see pull requests that
4.x-branch contains the latest version. Please target that branch in the PR.This change addresses issue: #2111 / #2114