Skip to content

Fix strict mode .length lookup on string primitives #2165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kibertoad merged 1 commit into from
Jun 14, 2026
+20 −1
Merged

Fix strict mode .length lookup on string primitives #2165

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/handlebars/runtime.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -109,7 +109,7 @@ export function template(templateSpec, env) {
// Just add water
let container = {
strict: function (obj, name, loc) {
if (!obj || !(name in obj)) {
if (obj == null || !(name in Object(obj))) {
throw new Exception('"' + name + '" not defined in ' + obj, {
loc: loc,
});
Expand Down
19 changes: 19 additions & 0 deletions spec/strict.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,25 @@ describe('strict', function () {
.toCompileTo('');
});

it('should handle array length', function () {
expectTemplate('{{hello.length}}')
.withCompileOptions({ strict: true })
.withInput({ hello: [1, 2, 3] })
.toCompileTo('3');
});

it('should handle string length', function () {
expectTemplate('{{hello.length}}')
.withCompileOptions({ strict: true })
.withInput({ hello: 'world' })
.toCompileTo('5');

expectTemplate('{{hello.length}}')
.withCompileOptions({ strict: true })
.withInput({ hello: '' })
.toCompileTo('0');
});

it('should error on missing property lookup in known helpers mode', function () {
expectTemplate('{{hello}}')
.withCompileOptions({
Expand Down
Loading