Update Experimental CMAKE_IMPORT_STD Flags - #354
Merged
Conversation
Owner
|
please make the change minimal and don't do reformating |
MathewBensonCode
force-pushed
the
cmake_import_std
branch
from
February 19, 2026 22:36
c0b141f to
1fa5a17
Compare
In order to use the Experimental CMAKE_IMPORT_STD flags, the experimental guid was hard-coded into the cmake file. CMake has however updated this Guid twice now, making it impossible to use the Module functionality with newer cmake versions. I have added the corresponding Guids with some "Ifs" and "Elses" to match the CMake version number being used in order to make it a bit more resilient.
MathewBensonCode
force-pushed
the
cmake_import_std
branch
from
February 19, 2026 22:58
1fa5a17 to
912a739
Compare
Author
|
My Apology for the formatting changes. I have factored in the removal of the experimental state in version 4.3 This change is likely to be beneficial to those using older versions of cmake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In order to use the Experimental CMAKE_IMPORT_STD flags, the experimental guid was hard-coded into the cmake file.
CMake has however updated this Guid twice now, making it impossible to use the Module functionality with newer cmake versions.
I have added the corresponding Guids with some "Ifs" and "Elses" to match the CMake version number being used in order to make it a bit more resilient.