Skip to content

Commit 1c04ace

Browse files
[ci]: pin VSA training regression to H100 (#1591)
1 parent 6cbff73 commit 1c04ace

4 files changed

Lines changed: 10 additions & 27 deletions

File tree

fastvideo/tests/contract/test_modal_fa4_policy.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -56,6 +56,11 @@ def test_performance_lane_classifies_pull_requests_before_main():
5656
"BUILDKITE_PULL_REQUEST") < function_strings.index("BUILDKITE_BRANCH")
5757

5858

59+
def test_vsa_training_lane_uses_strict_h100_pair():
60+
function_strings = _function_strings(PR_TEST, "run_training_tests_VSA")
61+
assert "H100!:2" in function_strings.splitlines()
62+
63+
5964
def test_pr_model_load_and_training_lanes_disable_fa4():
6065
lanes = {
6166
"run_transformer_tests": "pytest ./fastvideo/tests/transformers -vs",

fastvideo/tests/modal/pr_test.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -229,7 +229,7 @@ def run_training_lora_tests():
229229
)
230230

231231

232-
@app.function(gpu="H100:2",
232+
@app.function(gpu="H100!:2",
233233
image=image,
234234
timeout=900,
235235
secrets=[wandb_secret, ci_env_secret])

fastvideo/tests/training/VSA/h200_reference_wandb_summary_VSA.json

Lines changed: 0 additions & 18 deletions
This file was deleted.

fastvideo/tests/training/VSA/test_training_loss_VSA.py

Lines changed: 4 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -18,8 +18,7 @@
1818
from fastvideo.utils import FlexibleArgumentParser
1919

2020
wandb_name = "test_training_loss_VSA"
21-
h100_reference_wandb_summary_file = "fastvideo/tests/training/VSA/h100_reference_wandb_summary_VSA.json"
22-
h200_reference_wandb_summary_file = "fastvideo/tests/training/VSA/h200_reference_wandb_summary_VSA.json"
21+
reference_wandb_summary_file = "fastvideo/tests/training/VSA/h100_reference_wandb_summary_VSA.json"
2322

2423
NUM_NODES = "1"
2524
NUM_GPUS_PER_NODE = "2"
@@ -110,12 +109,9 @@ def test_distributed_training():
110109
summary_file = 'data/wan_finetune_test_VSA/tracker/wandb/latest-run/files/wandb-summary.json'
111110

112111
device_name = torch.cuda.get_device_name()
113-
if "H100" in device_name:
114-
reference_wandb_summary_file = h100_reference_wandb_summary_file
115-
elif "H200" in device_name:
116-
reference_wandb_summary_file = h200_reference_wandb_summary_file
117-
else:
118-
raise ValueError(f"Unknown device: {device_name}")
112+
print(f"INFO: device: {device_name}")
113+
if "H100" not in device_name:
114+
raise ValueError(f"VSA training regression requires H100 GPUs, got: {device_name}")
119115

120116
reference_wandb_summary = json.load(open(reference_wandb_summary_file))
121117
wandb_summary = json.load(open(summary_file))

0 commit comments

Comments
 (0)