Skip to content

Commit 809552c

Browse files
committed
fix(rvm): make MJ asset revisions immutable
1 parent bab0ab2 commit 809552c

1 file changed

Lines changed: 17 additions & 1 deletion

File tree

examples/train/rvm_h3/01_download_mj_video.sh

Lines changed: 17 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,9 +14,11 @@ hf_download() {
1414

1515
mkdir -p "${RVM_REWARD_ROOT}"
1616

17+
# These values must match fastvideo/train/methods/rl/rewards/mj_video.py.
18+
# They are intentionally not environment-overridable for reported runs.
1719
MJ_VIDEO_SOURCE_COMMIT="cc1d2c9587a620e9ebd3599ae4cdd21b5fd7c87a"
1820
MJ_VIDEO_MODEL_REVISION="5d32c2416bf5ffb9331a175890744e73defb54c4"
19-
MJ_VIDEO_BASE_REVISION="${MJ_VIDEO_BASE_REVISION:-e4f6747}"
21+
MJ_VIDEO_BASE_REVISION="e4f6747"
2022

2123
if [[ ! -d "${MJ_VIDEO_RUNTIME_PATH}/.git" ]]; then
2224
rm -rf "${MJ_VIDEO_RUNTIME_PATH}"
@@ -45,6 +47,20 @@ require_path "${MJ_VIDEO_MODEL_PATH}/model.safetensors"
4547
require_path "${MJ_VIDEO_BASE_MODEL_PATH}/config.json"
4648
require_path "${MJ_VIDEO_BASE_MODEL_PATH}/model.safetensors"
4749

50+
OBSERVED_SOURCE="$(git -C "${MJ_VIDEO_RUNTIME_PATH}" rev-parse HEAD)"
51+
if [[ "${OBSERVED_SOURCE}" != "${MJ_VIDEO_SOURCE_COMMIT}" ]]; then
52+
echo "MJ-VIDEO source revision mismatch: expected ${MJ_VIDEO_SOURCE_COMMIT}, got ${OBSERVED_SOURCE}." >&2
53+
exit 1
54+
fi
55+
if [[ "$(<"${MJ_VIDEO_MODEL_PATH}/.fastvideo_revision")" != "${MJ_VIDEO_MODEL_REVISION}" ]]; then
56+
echo "MJ-VIDEO checkpoint revision marker mismatch." >&2
57+
exit 1
58+
fi
59+
if [[ "$(<"${MJ_VIDEO_BASE_MODEL_PATH}/.fastvideo_revision")" != "${MJ_VIDEO_BASE_REVISION}" ]]; then
60+
echo "InternVL2 base revision marker mismatch." >&2
61+
exit 1
62+
fi
63+
4864
cat <<EOF
4965
Downloaded:
5066
MJ-VIDEO code: ${MJ_VIDEO_RUNTIME_PATH} @ ${MJ_VIDEO_SOURCE_COMMIT}

0 commit comments

Comments
 (0)