Skip to content

Commit 8ccbc6e

Browse files
committed
[bugfix]: validate GenRL prompt sampler dataset size
1 parent cab9b30 commit 8ccbc6e

1 file changed

Lines changed: 8 additions & 2 deletions

File tree

  • fastvideo/train/methods/rl/utils

fastvideo/train/methods/rl/utils/data.py

Lines changed: 8 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -149,7 +149,7 @@ def __init__(
149149
):
150150
self.dataset = dataset
151151
self.batch_size = batch_size
152-
self.k = k
152+
self.k = k # Repeats/videos per prompt.
153153
self.num_replicas = num_replicas
154154
self.rank = rank
155155
self.seed = seed
@@ -165,7 +165,13 @@ def __init__(
165165
f"num_replicas={num_replicas} "
166166
f"batch_size={batch_size}"
167167
)
168-
self.m = self.total_samples // self.k
168+
self.m = self.total_samples // self.k # Unique prompts across ranks.
169+
if len(self.dataset) < self.m:
170+
raise ValueError(
171+
"dataset must contain at least one prompt per global "
172+
"prompt group. Got "
173+
f"dataset_size={len(self.dataset)}, required={self.m}."
174+
)
169175
self.groups_per_rank = self.batch_size // self.k
170176
self.epoch = 0
171177

0 commit comments

Comments
 (0)