Skip to content

Consolidate examples and scripts - #1162

Open
HaripraveenS wants to merge 2 commits into
hao-ai-lab:mainfrom
HaripraveenS:consolidate-examples-and-scripts
Open

Consolidate examples and scripts#1162
HaripraveenS wants to merge 2 commits into
hao-ai-lab:mainfrom
HaripraveenS:consolidate-examples-and-scripts

Conversation

@HaripraveenS

Copy link
Copy Markdown

Consolidated examples and scripts folders. manually checked all changes.
Moved all files to examples folder since it had significantly more files.

@HaripraveenS
HaripraveenS marked this pull request as draft March 9, 2026 15:34
@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly refactors the project's directory structure by consolidating the scripts and examples folders into a single, unified examples directory. This change aims to improve code organization, making it easier for developers to locate and utilize example code and utility scripts, thereby enhancing overall project maintainability and clarity.

Highlights

  • Directory Consolidation: The scripts/ directory has been fully merged into the examples/ directory to centralize all example and utility scripts.
  • Path Updates: All internal references within documentation files and various scripts have been updated to reflect the new examples/ directory structure.
  • Minor Renaming: The examples/dataset directory was renamed to examples/datasets for consistency.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • docs/contributing/coding_agents.md
    • Updated script paths from scripts/huggingface/download_hf.py to examples/huggingface/download_hf.py.
    • Updated script paths from scripts/checkpoint_conversion/create_hf_repo.py to examples/checkpoint_conversion/create_hf_repo.py.
  • docs/distillation/data_preprocess.md
    • Updated script paths for downloading Hugging Face datasets.
    • Updated script paths for preprocessing data.
  • docs/distillation/dmd.md
    • Updated script paths for inference and downloading Hugging Face datasets.
  • docs/inference/inference_quick_start.md
    • Updated the path reference for inference example scripts.
  • docs/training/data_preprocess.md
    • Updated script paths for downloading Hugging Face datasets and preparing JSON files.
  • docs/training/finetune.md
    • Updated script paths for LoRA extraction, merging, and inference comparison.
  • docs/utilities/lora.md
    • Updated script paths for LoRA extraction, merging, and validation.
  • examples/distill/SFWan2.1-T2V/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/distill/Wan2.1-T2V/Wan-Syn-Data-480P/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/distill/Wan2.2-TI2V-5B-Diffusers/crush_smol/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/training/finetune/Wan2.1-Fun-1.3B-InP/crush_smol/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/training/finetune/Wan2.1-VSA/Wan-Syn-Data/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/training/finetune/wan_i2v_14B_480p/crush_smol/download_dataset.sh
    • Updated the download_hf.py script path.
  • examples/training/finetune/wan_t2v_1.3B/crush_smol/download_dataset.sh
    • Updated the download_hf.py script path.
  • fastvideo/tests/lora_extraction/test_lora_extraction.py
    • Updated the import path for lora extraction scripts.
  • scripts/checkpoint_conversion/convert_turbodiffusion_to_diffusers.py
    • Updated the suggested path for create_hf_repo.py in the output message.
  • scripts/checkpoint_conversion/longcat_to_fastvideo.py
    • Updated usage example path.
  • scripts/inference/v1_inference_longcat.sh
    • Updated usage example path and conversion method path.
  • scripts/inference/v1_inference_longcat_distill.sh
    • Updated usage example path.
  • scripts/inference/v1_inference_longcat_i2v.sh
    • Updated usage example path.
  • scripts/inference/v1_inference_longcat_refine_fromvideo.sh
    • Updated usage example path.
  • scripts/inference/v1_inference_longcat_vc.sh
    • Updated usage example path.
  • scripts/lora_extraction/extract_lora.py
    • Updated usage example path.
  • scripts/preprocess/launch_slurm_text.sh
    • Updated script paths for syn_text.slurm.
Activity
  • No specific activity (comments, reviews, progress) was provided for this pull request.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request consolidates the scripts and examples directories into a single examples directory. This is a large refactoring that involves moving numerous files and updating their paths across the codebase, including in documentation, shell scripts, and Python scripts. The changes appear to be comprehensive and consistent with the stated goal. I have reviewed the modifications in the provided diffs and found them to be correct. No issues were identified in the changed lines of code.

@HaripraveenS
HaripraveenS force-pushed the consolidate-examples-and-scripts branch from b81becf to 64f8220 Compare March 10, 2026 05:00
@HaripraveenS
HaripraveenS marked this pull request as ready for review March 11, 2026 05:29
@loaydatrain loaydatrain added the go label Mar 12, 2026
@loaydatrain

Copy link
Copy Markdown
Collaborator

@SolitaryThinker is there a point to keeping the bash scripts in examples/inference/cli/ (originally in scripts/inference/)? We already have python inference scripts under examples/inference/basic

@mergify

mergify Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Buildkite CI tests failed

Hi @HaripraveenS, some Buildkite CI tests have failed. Check the build for details:
View Buildkite build →

Common causes:

  • Test failures: Check the failing step's output for assertion errors or tracebacks
  • Import errors: Make sure new dependencies are added to pyproject.toml
  • GPU memory: Some tests require specific GPU types (L40S, H100 NVL)
  • Kernel build: If you changed fastvideo-kernel/, the build may have failed

If the failure is unrelated to your changes, leave a comment explaining why.

@mergify mergify Bot added scope: training Training pipeline, methods, configs scope: inference Inference pipeline, serving, CLI scope: data Data preprocessing, datasets scope: infra CI, tests, Docker, build scope: docs Documentation labels Mar 30, 2026
@mergify

mergify Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

⚠️ PR title format required

Your PR title must start with a type tag in brackets. Examples:

  • [feat] Add new model support
  • [bugfix] Fix VAE tiling corruption
  • [refactor] Restructure training pipeline
  • [perf] Optimize attention kernel
  • [ci] Update test infrastructure
  • [docs] Add inference guide
  • [misc] Clean up configs
  • [new-model] Port Flux2 to FastVideo

Valid tags: feat, feature, bugfix, fix, refactor, perf, ci, doc, docs, misc, chore, kernel, new-model

Please update your PR title and the merge protection check will pass automatically.

@mergify

mergify Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

🔴 PR merge requirements

Waiting for

  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
This rule is failing.
  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
  • check-success~=pre-commit

@mergify

mergify Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

Buildkite CI tests failed

Hi @HaripraveenS, some Buildkite CI tests have failed. Check the build for details:
View Buildkite build →

Common causes:

  • Test failures: Check the failing step's output for assertion errors or tracebacks
  • Import errors: Make sure new dependencies are added to pyproject.toml
  • GPU memory: Some tests require specific GPU types (L40S, H100 NVL)
  • Kernel build: If you changed fastvideo-kernel/, the build may have failed

If the failure is unrelated to your changes, leave a comment explaining why.

@mergify

mergify Bot commented Mar 30, 2026

Copy link
Copy Markdown
Contributor

❌ CI tests failed

@HaripraveenS — to see what failed:

  1. Scroll to the Checks section below
  2. Find the check marked with ❌ (e.g. buildkite/ci/microscope-transformer-tests)
  3. Click Details to view the full build log

Or view all builds for this branch on Buildkite →

Common causes:

  • Assertion error / test failure — check the failing test's traceback
  • Import error — new dependency missing from pyproject.toml
  • OOM — some tests need specific GPUs (L40S, H100 NVL)

If the failure looks unrelated to your changes, comment why and a maintainer will review.

@mergify

mergify Bot commented May 29, 2026

Copy link
Copy Markdown
Contributor

This PR has merge conflicts with the base branch. Please rebase:

git fetch origin main
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease

@mergify mergify Bot added the needs-rebase PR has merge conflicts label May 29, 2026
@github-actions

Copy link
Copy Markdown

This pull request has been automatically marked as stale because it has not had any activity within 60 days. It will be automatically closed if no further activity occurs within 14 days. Leave a comment if you feel this pull request should remain open. Thank you!

@github-actions github-actions Bot added the stale Inactive — will auto-close soon label Jul 29, 2026
@mergify

mergify Bot commented Jul 29, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews, 🤖 CI and 🙋 you

Protection Waiting on
🔴 PR merge requirements 👀 reviews, 🤖 CI and 🙋 you

🔴 PR merge requirements

Waiting for

  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
This rule is failing.
  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
  • check-success~=pre-commit

@github-actions github-actions Bot removed the stale Inactive — will auto-close soon label Jul 30, 2026
@github-actions github-actions Bot added the unstale Reactivated after being stale label Jul 30, 2026
@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

This PR has merge conflicts with the base branch. Please rebase:

git fetch origin main
git rebase origin/main
# Resolve any conflicts, then:
git push --force-with-lease

@mergify

mergify Bot commented Jul 30, 2026

Copy link
Copy Markdown
Contributor

Merge Protections

🔴 1 of 1 protections blocking · waiting on 👀 reviews, 🤖 CI and 🙋 you

Protection Waiting on
🔴 PR merge requirements 👀 reviews, 🤖 CI and 🙋 you

🔴 PR merge requirements

Waiting for

  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
This rule is failing.
  • #approved-reviews-by>=1
  • check-success=fastcheck-passed
  • check-success=full-suite-passed
  • title~=(?i)^\[(feat|feature|bugfix|fix|refactor|perf|ci|doc|docs|misc|chore|kernel|new.?model|skill|skills|infra)\]
  • check-success~=pre-commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

needs-rebase PR has merge conflicts scope: data Data preprocessing, datasets scope: docs Documentation scope: inference Inference pipeline, serving, CLI scope: infra CI, tests, Docker, build scope: training Training pipeline, methods, configs unstale Reactivated after being stale

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants